Re: [PATCH] 2.4.34 - Add some ahci pci ids

Willy Tarreau
2007-06-06T05:43:21Z

On Fri, Jun 01, 2007 at 07:40:54AM -0400, Jeff Garzik wrote:
> Filippo Carletti wrote:
> >This patch adds support for some chipsets in ahci driver.
> >The list comes from a patch for redhat kernel 2.6.9-34.
> >I only tested ICH8.
> >
> >The original patch contained also this lines (that I omitted):
> >+ /* JMicron-specific fixup: make sure we're in AHCI mode */
> >+ if (pdev->vendor == 0x197b)
> >+ pci_write_config_byte(pdev, 0x41, 0xa1);
>
> NAK. Don't omit obviously needed lines, if you are going to add JMicron
> PCI IDs.

Filippo,

would you please resend your patch including the lines you have omitted ?
Jeff is right, those lines are explicitly labelled as a fixup, so either
we merge the complete patch, or nothing at all.

I expect to release 2.4.35 around the end of this month, so if you can
provide me with an acceptable patch in time so that I can run at least
one -rc with it, I'm OK to merge it (provided that Jeff has no objection
of course). I will merge your other patch (VIA) at the same time.

Thanks in advance,
Willy