From: Paul Mundt <lethal@linux-sh.org>
To: Richard Purdie <rpurdie@openedhand.com>
Cc: akpm <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Nitin Gupta <nitingupta910@gmail.com>
Subject: Re: [PATCH -mm] Add LZO1X compression support to the kernel
Date: Thu, 7 Jun 2007 15:06:18 +0900 [thread overview]
Message-ID: <20070607060618.GA14759@linux-sh.org> (raw)
In-Reply-To: <1181150792.5686.51.camel@localhost.localdomain>
On Wed, Jun 06, 2007 at 06:26:32PM +0100, Richard Purdie wrote:
> +/* Which machines to allow unaligned accesses on */
> +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64)
> +#define LZO_UNALIGNED_OK_2
> +#define LZO_UNALIGNED_OK_4
> +#endif
> +
This is silly, just use get/put_unaligned(). This same issue was pointed
out in Nitin's patch and already corrected there, perhaps it would be
more constructive to work on getting cleanups from both implementations
integrated in to something mergeable rather than trying to see who can
get in to -mm first.
prev parent reply other threads:[~2007-06-07 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 17:26 [PATCH -mm] Add LZO1X compression support to the kernel Richard Purdie
2007-06-07 4:41 ` Nitin Gupta
2007-06-07 8:27 ` Richard Purdie
2007-06-07 8:53 ` Nitin Gupta
2007-06-07 6:06 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070607060618.GA14759@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nitingupta910@gmail.com \
--cc=rpurdie@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox