Re: 2.6.22-rc4-mm1

Andrew Morton
2007-06-11T06:28:16Z

On Sun, 10 Jun 2007 22:01:34 -0700 "Dan Williams" <dan.j.williams@intel.com> wrote:

> It would be very helpful to have a clear merge path for dmaengine
> changes and the async offload api.

Yes, this needs some attention.

I'd suggest that you prepare a standalone tree for Linus to pull and we aim at
asking him to pull that for 2.6.23-rc1.

In the meanwhile I'd suggest that you get the core patch(es) out
onto the relevant lists again and cc'ed to the relevant maintainers.

Of course, good changelogging and commenting makes the review a) more
effective, b) more likely to happen and c) less work for reviewers. The
changelog you have for 7556477664edcbe1c9a2fdf60edddfd8455d198b is nice,
but it's awfully short for a 1/4MB patch. It tells us at a high level what
the code does, but it has nothing to say about how it does it: a high-level
design description, of you will.

Put yourself in the position of an experienced kernel developer who doesn't
know this code, and who doesn't know the hardware. What can you do to make
their review easier and more effective?

So. Please have a think about what you can do there, and also see what can
be done about the 312 warnings which

perl scripts/checkpatch.pl patches/git-md-accel.patch

emits. Then send 'em all out again (say, a week from now) and let's all just dig
in and make this thing happen?