Re: 2.6.22-rc4-mm1

Greg KH
2007-06-07T16:00:15Z

On Thu, Jun 07, 2007 at 11:25:57AM -0400, Peter Jones wrote:
> Kay Sievers wrote:
> > On Thu, 2007-06-07 at 11:41 +0200, Michal Piotrowski wrote:
> >> Kay Sievers pisze:
> >>> On Thu, 2007-06-07 at 10:40 +0200, Michal Piotrowski wrote:
> >>>> Kay Sievers pisze:
> >>>>> On Wed, 2007-06-06 at 20:48 +0200, Michal Piotrowski wrote:
> >>>>>> Andrew Morton pisze:
> >>>>>>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm1/
> >>>>>>>
> >>>>>> Kay, your patch gregkh-driver-block-device.patch breaks Fedora 7
> >>>>>> initrd
> >>>>>> http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/2.6.22-rc4-mm1/initrd.jpg
> >>>>>>
> >>>>>> Please fix it ASAP, I can't test kernel...
> >>>>> Do you have CONFIG_SYSFS_DEPRECATED set or unset?
> >>>>>
> >>>>> Kay
> >>>>>
> >>>>>
> >>>> cat ../linux-mm-bo/.config | grep CONFIG_SYSFS_DEPRECATED
> >>>> # CONFIG_SYSFS_DEPRECATED is not set
> >>> Oh, could you possibly try (with the block patch included) setting it to
> >>> yes and see if it works? That would help to find what's going wrong.
> >> I enabled CONFIG_SYSFS_DEPRECATED and 2.6.22-rc4-mm2 boots fine.
> > Michal, thanks a lot for the testing.
> > Peter, looking at your mkinitrd code, it works only with
> > CONFIG_SYSFS_DEPRECATED enabled when block devices are converted to
> > class devices.
> > Any chance to replace lstat() with stat() while looking for devices in
> > sysfs? Remember, _anything_ in sysfs can be symlink or a directory, you
> > can't assume one or the other. When things change internally in the
> > kernel, we can often provide symlinks for backwards compatibility, but
> > lstat() obviously can't works here.
>
> Fixed in mkinitrd-6.0.9-6 , which I'll build now and push to
> updates-testing. Thanks for getting my attention here.

Great, Andrew, can you please reenable the block-device patch that is in
my tree now that the problem has been solved?

thanks,

greg k-h