From: Andrew Morton <akpm@linux-foundation.org>
To: Anton Blanchard <anton@samba.org>
Cc: Will Schmidt <will_schmidt@vnet.ibm.com>,
linux-kernel@vger.kernel.org, liuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/3] [PATCH i386] during VM oom condition, kill all threads in process group
Date: Thu, 7 Jun 2007 17:10:18 -0700 [thread overview]
Message-ID: <20070607171018.d51fc5da.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070607231621.GB32549@kryten>
On Thu, 7 Jun 2007 18:16:21 -0500
Anton Blanchard <anton@samba.org> wrote:
>
> Hi,
>
> > zap_other_threads() requires tasklist_lock.
> >
> > If we're going to do this then we should probably create some new function
> > (with a better name) which takes tasklsit_lock and then calls
> > zap_other_threads().
> >
> > Does this patch fix any observed-in-the-real-world problem? If so, please
> > describe it.
>
> Yeah we have had complaints where threaded apps have only one thread
> shot down instead of the entire process. This leaves the application in
> a bad state, whereas if it had been killed cleanly the application could
> have restarted.
>
> My understanding is that fatal signals should kill all threads in the
> group.
>
OK, well could we please get all that info appropriatelt captured in #2's
changelog?
Other architectures will probably need to implement this.
next prev parent reply other threads:[~2007-06-08 0:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-05 17:48 [PATCH 1/3] [PATCH i386] during VM oom condition, kill all threads in process group Will Schmidt
2007-06-05 17:48 ` [PATCH 2/3] [PATCH powerpc] " Will Schmidt
2007-06-05 18:17 ` Will Schmidt
2007-06-05 17:48 ` [PATCH 3/3] [PATCH x86_64] " Will Schmidt
2007-06-07 22:34 ` [PATCH 1/3] [PATCH i386] " Andrew Morton
2007-06-07 23:16 ` Anton Blanchard
2007-06-08 0:10 ` Andrew Morton [this message]
2007-06-08 19:19 ` Will Schmidt
2007-06-08 19:32 ` Andrew Morton
2007-06-08 21:12 ` Will Schmidt
2007-06-08 22:48 ` Eric W. Biederman
2007-06-13 15:51 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070607171018.d51fc5da.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxppc-dev@ozlabs.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox