From: Ingo Molnar <mingo@elte.hu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Eric Dumazet <dada1@cosmosbay.com>
Subject: Re: [patch 4/4] FUTEX: Tidy up the code
Date: Fri, 8 Jun 2007 09:10:45 +0200 [thread overview]
Message-ID: <20070608071045.GA30226@elte.hu> (raw)
In-Reply-To: <20070607235801.624243000@linutronix.de>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> The recent PRIVATE and REQUEUE_PI changes to the futex code made it hard to read.
> Tidy it up.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
looks good to me:
Acked-by: Ingo Molnar <mingo@elte.hu>
> - if (!pi) {
> - if (uval & FUTEX_WAITERS)
> + if (!pi && (uval & FUTEX_WAITERS))
> futex_wake(uaddr, &curr->mm->mmap_sem, 1);
> - }
one too much tab left in the futex_wake line i guess?
Ingo
prev parent reply other threads:[~2007-06-08 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 0:29 [patch 0/4] PI-Futex bugfixes and cleanups Thomas Gleixner
2007-06-08 0:29 ` [patch 1/4] rt-mutex: Fix stale return value Thomas Gleixner
2007-06-08 7:20 ` Ingo Molnar
2007-06-08 0:29 ` [patch 2/4] rt-mutex: Fix chain walk early wakeup bug Thomas Gleixner
2007-06-08 7:18 ` Ingo Molnar
2007-06-08 0:29 ` [patch 3/4] pi-futex: Fix exit races and locking problems Thomas Gleixner
2007-06-08 7:16 ` Ingo Molnar
2007-06-08 0:29 ` [patch 4/4] FUTEX: Tidy up the code Thomas Gleixner
2007-06-08 7:10 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608071045.GA30226@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox