Re: [patch 23/32] IPV4: Correct rp_filter help text.

Herbert Xu
2007-06-09T01:22:22Z

On Sat, Jun 09, 2007 at 11:20:43AM +1000, Herbert Xu wrote:
> Chris Wright <chrisw@sous-sol.org> wrote:
> >
> > --- linux-2.6.20.13.orig/net/ipv4/Kconfig
> > +++ linux-2.6.20.13/net/ipv4/Kconfig
> > @@ -43,11 +43,11 @@ config IP_ADVANCED_ROUTER
> > asymmetric routing (packets from you to a host take a different path
> > than packets from that host to you) or if you operate a non-routing
> > host which has several IP addresses on different interfaces. To turn
> > - rp_filter off use:
> > + rp_filter on use:
> >
> > - echo 0 > /proc/sys/net/ipv4/conf/<device>/rp_filter
> > + echo 1 > /proc/sys/net/ipv4/conf/<device>/rp_filter
> > or
> > - echo 0 > /proc/sys/net/ipv4/conf/all/rp_filter
> > + echo 1 > /proc/sys/net/ipv4/conf/all/rp_filter
>
> BTW, this documentation is actually wrong. You can't enable rp_filter

So to fix the documentation, we should change the word "or" to "and".

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt