Re: [patch 03/54] NOHZ: Rate limit the local softirq pending warning output

Thomas Gleixner
2007-06-08T10:51:07Z

On Fri, 2007-06-08 at 12:34 +0200, Daniel Thaler wrote:
> Chris Wright wrote:
> > -stable review patch. If anyone has any objections, please let us know.
> > ---------------------
> >
> > From: Thomas Gleixner <tglx@linutronix.de>
> >
> > The warning in the NOHZ code, which triggers when a CPU goes idle with
> > softirqs pending can fill up the logs quite quickly. Rate limit the output
> > until we found the root cause of that problem.
>
> Isn't the root cause found and fixed with "[patch 09/54] Prevent going
> idle with softirq pending"?

Yes, still we want the printk there to find places, which go into idle
with softirqs pending. There is at least one problem in the SLIP code,
which triggers this. OTOH we do not want those messages to flood the
syslog.

tglx