From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Fulghum <paulkf@microgate.com>
Cc: "Björn Steinbrink" <B.Steinbrink@gmx.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"Nicolas Mailhot" <nicolas.mailhot@laposte.net>,
"Randy Dunlap" <randy.dunlap@oracle.com>,
"bugme-daemon@kernel-bugs.osdl.org"
<bugme-daemon@bugzilla.kernel.org>,
linux-kernel@vger.kernel.org, "Mel Gorman" <mel@csn.ul.ie>,
"Christoph Lameter" <clameter@sgi.com>
Subject: Re: [Bug 8473] New: Oops: 0010 [1] SMP
Date: Fri, 8 Jun 2007 12:33:50 -0700 [thread overview]
Message-ID: <20070608123350.5cc53c10.akpm@linux-foundation.org> (raw)
In-Reply-To: <1181330448.5365.7.camel@amdx2.microgate.com>
On Fri, 08 Jun 2007 14:20:48 -0500
Paul Fulghum <paulkf@microgate.com> wrote:
> On Fri, 2007-06-08 at 10:16 -0500, Paul Fulghum wrote:
> > On Fri, 2007-06-08 at 05:06 +0200, Bj__rn Steinbrink wrote:
> > > This is do_tty_hangup() exchanging the fops while we're waiting for the
> > > lock. The new fops (hung_up_tty_fops) only have the unlocked variant and
> > > thus we Oops our way.
> ...
> > Here is a patch that restores the locked ioctl for hung_up_tty_ioctl.
> > Can you try it and see if it removes your oops?
>
> Unfortunately I can't get the timing right to trigger this,
> but it is very clear the locked ioctl fop must not be
> allowed to disappear like my original patch allows.
>
> Andrew:
>
> Would you prefer I resend the entire compat ioctl patch or
> submit an incremental patch like in my message I'm quoting above?
>
The compat_ioctl patch is in mainline, and has been for some time.
Hence a patch against mainline would be appropriate, thanks.
next prev parent reply other threads:[~2007-06-08 19:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705132102.l4DL2onF003014@fire-2.osdl.org>
2007-05-13 22:47 ` [Bug 8473] New: Oops: 0010 [1] SMP Andrew Morton
2007-05-13 23:25 ` Nicolas Mailhot
2007-05-17 10:00 ` Nicolas Mailhot
2007-05-17 16:45 ` Randy Dunlap
2007-05-17 16:59 ` Nicolas Mailhot
2007-05-26 19:10 ` Nicolas Mailhot
2007-06-08 3:06 ` Björn Steinbrink
2007-06-08 3:16 ` Andrew Morton
2007-06-08 14:10 ` Paul Fulghum
2007-06-08 15:16 ` Paul Fulghum
2007-06-08 19:20 ` Paul Fulghum
2007-06-08 19:33 ` Andrew Morton [this message]
2007-06-08 20:34 ` [PATCH] tty restore locked ioctl file op Paul Fulghum
2007-06-09 18:18 ` Björn Steinbrink
2007-06-09 21:52 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608123350.5cc53c10.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=B.Steinbrink@gmx.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=nicolas.mailhot@laposte.net \
--cc=paulkf@microgate.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox