public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jcm@jonmasters.org, Jan Engelhardt <jengelh@computergmbh.de>,
	Jesper Juhl <jesper.juhl@gmail.com>,
	Andy Whitcroft <apw@shadowen.org>, Andrew Morton <akpm@osdl.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Joel Schopp <jschopp@austin.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.03
Date: Fri, 8 Jun 2007 14:39:42 +0200	[thread overview]
Message-ID: <20070608123942.GZ5500@stusta.de> (raw)
In-Reply-To: <20070608115219.694c642d@the-village.bc.nu>

On Fri, Jun 08, 2007 at 11:52:19AM +0100, Alan Cox wrote:
> > The problem is that the second byte is interpreted as a control code.
> > 
> > Is there any trick to get the shell working again in this situation?
> > The cursor hangs, and I've not yet found a trick to do anything in this
> > xterm again (except for killing it from another xterm).
> 
> For gnome terminal just select 'reset terminal' in the menu or escape-[c;
>  (from memory) is the VT reset code. If your xterm can be stuck forever
> file a security bug against your vendors xterm for a DoS attack problem.

Someone else already told me this trick, and the "Full Reset" from the 
Control + middle mouse button menu works with my xterm.

Not a problem if you know about it or if you have time.

> > > "Require" is a rather strong word for a print formatting issue specific
> > > to obscure setups.
> > 
> > See obove, it's not only "print formatting", it's "kills my shell".
> 
> It printed a symbol, if your shell really got screwed that much by it
> then your shell needs work perhaps.

My shell is bash...

> I'm not btw arguing that we shouldn't
> teach the tools to be more polite, just that its hardly a "requirement"

For tools like ls or vim that have to deal with every kind of charset 
confusion for ages such issues have already been shaken out.

But tools don't expects the kernel to output non-ASCII strings.

It's not only about MODULE_AUTHOR, if you consider it rude to limit 
people's names to ASCII, then don't forget that we have printk's like
    Linux agpgart interface v0.102 (c) Dave Jones

What happens if the maintainer changes and it's now
     Linux agpgart interface v0.103 © Dave Ønes

Does the console handle it correctly during boot?
Can all tools that process the syslog cope with it?

Perhaps the answer is in both cases "yes", but it's a completely 
untested area.

We really must have all bugs shaken out and all users using fixed tools 
_before_ we can start outputting UTF-8 - limiting people's names to 
ASCII in not ideal, but IMHO causing breakages for users is a much 
bigger problem.

> Alan

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-06-08 12:39 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04  9:46 [PATCH] update checkpatch.pl to version 0.03 Andy Whitcroft
2007-06-04  9:55 ` [PATCH] update feature-removal-schedule.txt to include deprecated functions Andy Whitcroft
2007-06-04 15:49 ` [PATCH] update checkpatch.pl to version 0.03 jschopp
2007-06-04 16:51   ` Andy Whitcroft
2007-06-04 17:22     ` jschopp
2007-06-05 18:45       ` Andy Whitcroft
2007-06-05  9:56   ` Andy Whitcroft
2007-06-04 16:25 ` Jan Engelhardt
2007-06-04 18:41 ` Andrew Morton
2007-06-04 19:08   ` Andy Whitcroft
2007-06-04 19:08     ` Rene Herman
2007-06-04 20:04       ` Randy Dunlap
2007-06-05 18:39         ` Andy Whitcroft
2007-06-08  9:31       ` Andy Whitcroft
2007-06-08 10:08         ` Rene Herman
2007-06-05  8:14 ` Heiko Carstens
2007-06-06  9:05 ` Jesper Juhl
2007-06-07 14:28   ` Jan Engelhardt
2007-06-07 14:39     ` Jesper Juhl
2007-06-07 19:34     ` Adrian Bunk
2007-06-07 22:22       ` Alan Cox
2007-06-07 23:21         ` Adrian Bunk
2007-06-07 23:41           ` Alan Cox
2007-06-08  0:04             ` Adrian Bunk
2007-06-08  4:37               ` Jon Masters
2007-06-08  8:58               ` Jan-Benedict Glaw
2007-06-08 10:52               ` Alan Cox
2007-06-08 12:39                 ` Adrian Bunk [this message]
2007-06-08 14:34                   ` Jesper Juhl
2007-06-08 14:42                     ` Adrian Bunk
2007-06-08 15:16                       ` Jan Engelhardt
2007-06-08 15:37                         ` Jon Masters
2007-06-08 15:42                         ` Alan Cox
2007-06-08 16:39                           ` Adrian Bunk
2007-06-08 18:43                             ` Jan Engelhardt
2007-06-08 16:03                     ` Roland Dreier
2007-06-07 23:49           ` Adrian Bunk
2007-06-07 19:32   ` Adrian Bunk
2007-06-07 22:18     ` Alan Cox
2007-06-06 11:49 ` Jesper Juhl
2007-06-07 11:46   ` Andy Whitcroft
2007-06-07 11:52     ` Jesper Juhl
2007-06-07 15:16       ` checkpatch.pl: should be executable Andy Whitcroft
2007-06-07 15:33         ` jschopp
2007-06-07 14:22     ` [PATCH] update checkpatch.pl to version 0.03 Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070608123942.GZ5500@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=apw@shadowen.org \
    --cc=jcm@jonmasters.org \
    --cc=jengelh@computergmbh.de \
    --cc=jesper.juhl@gmail.com \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox