From: David Miller <davem@davemloft.net>
To: grundler@parisc-linux.org
Cc: auke-jan.h.kok@intel.com, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz, gregkh@suse.de
Subject: Re: [PATCH 1/2] [RFC] PCI: read revision ID by default
Date: Sat, 09 Jun 2007 01:02:49 -0700 (PDT) [thread overview]
Message-ID: <20070609.010249.77260306.davem@davemloft.net> (raw)
In-Reply-To: <20070609065953.GA1747@colo.lackof.org>
From: Grant Grundler <grundler@parisc-linux.org>
Date: Sat, 9 Jun 2007 00:59:53 -0600
> On Fri, Jun 08, 2007 at 03:46:30PM -0700, Auke Kok wrote:
> > Currently there are 97 occurrences where drivers need the pci
> > revision ID. We can do this once for all devices. Even the pci
> > subsystem needs the revision several times for quirks. The extra
> > u8 member pads out nicely in the pci_dev struct.
>
> Good idea. I always wondered why we read the invariants so often
> in the code.
BTW, if you add code like this, you also have to add the
appropriate code to do this for all the platforms that probe
the PCI bus using a firmware device tree like sparc64
and powerpc do.
next prev parent reply other threads:[~2007-06-09 8:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 22:46 [PATCH 1/2] [RFC] PCI: read revision ID by default Auke Kok
2007-06-08 22:46 ` [PATCH 2/2] [RFC] PCI: Change all drivers to use pci_device->revision Auke Kok
2007-06-11 15:19 ` Dave Jones
2007-06-09 6:59 ` [PATCH 1/2] [RFC] PCI: read revision ID by default Grant Grundler
2007-06-09 8:02 ` David Miller [this message]
2007-06-09 19:31 ` Kok, Auke
2007-06-09 19:48 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070609.010249.77260306.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=auke-jan.h.kok@intel.com \
--cc=gregkh@suse.de \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox