Re: [0/1] [patch -mm] Add containerstats (v3)

Andrew Morton
2007-06-09T08:02:32Z

On Sat, 9 Jun 2007 00:09:55 -0700 "Paul Menage" <menage@google.com> wrote:

> On 6/8/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Fri, 08 Jun 2007 23:43:46 +0530
> > Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> >
> > > This patch implements per container statistics infrastructure and re-uses
> > > code from the taskstats interface.
> >
> > boggle.
> >
> > Symbol: CONTAINERS [=y]
> > Selected by: CONTAINER_DEBUG || CPUSETS && SMP || CONTAINER_CPUACCT
> >
> > Paul, that's just bizarre. How come it was done this way?
>
> Containers on their own without any subsystems aren't hugely useful.
> So the plan was that any container subsystem would "select CONTAINERS"
> to cause the container framework to be built. I'm happy to change it
> to invert the dependencies if you'd prefer.
>

- CONTAINER_DEBUG should depend on CONTAINERS

- the CPUSETS && SMP is weird and should be deleted, unless I'm missing
something

- CONTAINERS should depend on CPUSETS

- That leaves CONTAINER_CPUACCT. One _could_ `select' CONTAINERS if
CONTAINER_CPUACCT but I suspect that'll screw up the above (select does
odd things). I think it's reasonable to have a CONTAINERS menu and under
that, all the clients of it: CONTAINER_CPUACCT, CONTAINER_MEMORY_CONTROL,
etc.