public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	Len Brown <lenb@kernel.org>
Subject: Re: Jinxed VAIO wreckage - current state of affairs
Date: Sat, 9 Jun 2007 22:59:49 +0200	[thread overview]
Message-ID: <200706092259.50694.rjw@sisk.pl> (raw)
In-Reply-To: <1181418873.4404.402.camel@chaos>

On Saturday, 9 June 2007 21:54, Thomas Gleixner wrote:
> Andrew's jinxed VAIO breaks with the high resolution timer updates in a
> very strange way. Andrew identified the following patch as the culprit:
> 
> http://www.tglx.de/projects/hrtimers/2.6.22-rc4/broken-out/clockevents-fix-resume-logic.patch
> 
> This makes no sense at all. The patch just moves the timer restart to a
> different (later) place in the code and does exactly the same thing as
> the current code does.
> 
> On resume the VAIO is stuck in the following place:
> 
> <Andrews debug session>
> 
> We finish swsusp_save() and a few other functions then we go
> 
>         hibernate
>         ->platform_finish
>           ->acpi_hibernation_finish
>             ->acpi_leave_sleep_state
>               ->acpi_evaluate_object
> 
> and there it dies, in this call:
> 
> status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);
> 
> I wonder how your patch caused that?
> 
> <debugs further>
> 
> OK, it gets to the last statement in acpi_evaluate_object():
> 
>         return_ACPI_STATUS(status);
> 
> but doesn't hit the printk on return to the caller,
> acpi_leave_sleep_state().
> 
> </Andrews debug session>
> 
> Some data points:
> 
> This happens only, when the local apic timer is used. With PIT the
> resume works fine.
> 
> I back ported the full high res stuff to 2.6.20. On 2.6.20 the VAIO
> survives that patch.
> 
> Can the suspend/resume and ACPI wizards please give some hint how to
> track this 100% reproducible wreckage down.

Hmm, how's 2.6.22-rc4-mm2 doing on the Vaio?

There are a couple of patches in there that might help in theory, this series
in particular:

swsusp-remove-incorrect-code-from-userc.patch
swsusp-remove-code-duplication-between-diskc-and-userc.patch
swsusp-introduce-restore-platform-operations.patch
swsusp-fix-hibernation-code-ordering.patch
swsusp-remove-code-duplication-between-diskc-and-userc-fix.patch

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth

  reply	other threads:[~2007-06-09 20:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-09 19:54 Jinxed VAIO wreckage - current state of affairs Thomas Gleixner
2007-06-09 20:59 ` Rafael J. Wysocki [this message]
2007-06-09 21:05   ` Thomas Gleixner
2007-06-10  3:08   ` Andrew Morton
2007-06-11  1:37     ` Thomas Davis
2007-06-15 12:05     ` Thomas Gleixner
2007-06-15 15:13       ` Johannes Weiner
2007-06-15 15:23       ` Randy Dunlap
2007-06-15 15:31         ` Thomas Gleixner
2007-06-16  6:31           ` Andrew Morton
2007-06-16  6:47             ` Thomas Gleixner
2007-06-16  6:53               ` Thomas Gleixner
2007-06-16  7:19                 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706092259.50694.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@osdl.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox