From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
Andi Kleen <ak@suse.de>, Arjan van de Ven <arjan@infradead.org>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Chris Wright <chrisw@sous-sol.org>
Subject: Re: [patch-mm 06/23] clockevents: Fix resume logic
Date: Sun, 10 Jun 2007 12:58:47 +0200 [thread overview]
Message-ID: <200706101258.48721.rjw@sisk.pl> (raw)
In-Reply-To: <1181471412.384.9.camel@chaos>
On Sunday, 10 June 2007 12:30, Thomas Gleixner wrote:
> On Sun, 2007-06-10 at 12:19 +0200, Rafael J. Wysocki wrote:
> > > -/*
> > > - * Suspend/resume part
> > > - */
> > > -
> > > -#ifdef CONFIG_PM
> > > -
> > > -static int hpet_suspend(struct sys_device *sys_device, pm_message_t state)
> > > -{
> > > - unsigned long cfg = hpet_readl(HPET_CFG);
> > > -
> > > - cfg &= ~(HPET_CFG_ENABLE|HPET_CFG_LEGACY);
> > > - hpet_writel(cfg, HPET_CFG);
> > > -
> > > - return 0;
> > > -}
> >
> > Hmm, I haven't found anything to replace the above in the patch. Is that
> > intentional, or is it there, but I haven't noticed?
>
> > > + case CLOCK_EVT_MODE_RESUME:
> > > + hpet_enable_int();
> > > + break;
This is the resume part, or at least it seems so, but the above one is a
suspend callback. If I understand it correctly, this one replaces
hpet_resume(), but is it sufficient for the suspend part too?
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
next prev parent reply other threads:[~2007-06-10 11:23 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-10 9:43 [patch-mm 00/23] High resolution timer updates and x86_64 support Thomas Gleixner
2007-06-10 9:43 ` [patch-mm 01/23] NOHZ: Fix ARM,SH,SPARC64 idle nohz handling Thomas Gleixner
2007-06-11 0:26 ` Paul Mundt
2007-06-11 5:20 ` Thomas Gleixner
2007-06-11 5:32 ` Paul Mundt
2007-06-10 9:44 ` [patch-mm 02/23] ACPI: Move timer broadcast and pmtimer access before C3 arbiter shutdown Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 03/23] Clockevents remove prototypes of removed functions Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 04/23] Timekeeping: Fixup shadow variable argument Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 05/23] timer.c cleanup recently introduced whitespace damage Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 06/23] clockevents: Fix resume logic Thomas Gleixner
2007-06-10 9:43 ` Nigel Cunningham
2007-06-10 9:51 ` Thomas Gleixner
2007-06-10 10:19 ` Rafael J. Wysocki
2007-06-10 10:30 ` Thomas Gleixner
2007-06-10 10:58 ` Rafael J. Wysocki [this message]
2007-06-10 13:17 ` Thomas Gleixner
2007-06-10 16:34 ` Rafael J. Wysocki
2007-06-10 18:45 ` Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 07/23] Tick management: spread timer interrupt Thomas Gleixner
2007-06-10 14:16 ` Andreas Mohr
2007-06-10 14:31 ` Thomas Gleixner
2007-06-10 14:35 ` Andreas Mohr
2007-06-10 9:44 ` [patch-mm 08/23] i386: PIT stop only, when in periodic or oneshot mode Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 09/23] clockevents: Fix device replacement Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 10/23] highres: Improve debug output Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 11/23] hrtimer: speedup hrtimer_enqueue Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 12/23] pcspkr: use the global PIT lock Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 13/23] i386: hpet assumes boot cpu is 0 Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 14/23] NTP: Move the cmos update code into ntp.c Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 15/23] x86_64: untangle asm/hpet.h from asm/timex.h Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 16/23] x86_64: Use generic cmos update Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 17/23] i386: move setup_pit_timer to the correct header file Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 18/23] x86-64: remove dead code and other janitor work in tsc.c Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 19/23] x86_64: Convert to cleckevents Thomas Gleixner
2007-06-11 8:47 ` Sébastien Dugué
2007-06-11 8:57 ` Thomas Gleixner
2007-06-11 19:12 ` [patch-mm 19a/23] x86_64: hpet restore vread Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 20/23] x86_64: restore restore nohpet cmdline Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 21/23] x86-64 block irq balancing for timer Thomas Gleixner
2007-06-10 16:29 ` Arjan van de Ven
2007-06-11 19:24 ` Pallipadi, Venkatesh
2007-06-10 9:44 ` [patch-mm 22/23] x86_64: prep idle loop for dynticks Thomas Gleixner
2007-06-10 9:44 ` [patch-mm 23/23] x86_64: enable high resolution timers and dynticks Thomas Gleixner
2007-06-10 22:46 ` [patch-mm 00/23] High resolution timer updates and x86_64 support Mark Lord
2007-06-11 5:19 ` Thomas Gleixner
2007-06-11 22:43 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706101258.48721.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox