From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: Andi Drebes <lists-receive@programmierforen.de>,
kernel-janitors@lists.osdl.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof
Date: Sun, 10 Jun 2007 15:14:02 +0200 [thread overview]
Message-ID: <20070610131402.GR2649@lug-owl.de> (raw)
In-Reply-To: <20070610131122.GB3588@pingi.kke.suse.de>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Sun, 2007-06-10 15:11:22 +0200, Karsten Keil <kkeil@suse.de> wrote:
> > --- a/drivers/isdn/hisax/callc.c
> > +++ b/drivers/isdn/hisax/callc.c
> > @@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata =
> > };
> > /* *INDENT-ON* */
> >
> > -#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
> > +#define FNCOUNT ARRAY_SIZE(fnlist)
> >
> > int __init
> > CallcNew(void)
>
> This is OK, thanks for changing.
I'd suggest to not use another define, but use ARRAY_SIZE(foo)
_instead of_ eg. FNCOUNT.
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Ich hatte in letzter Zeit ein bißchen viel Realitycheck.
the second : Langsam möchte ich mal wieder weiterträumen können.
-- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-06-10 13:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-10 10:35 [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof Andi Drebes
2007-06-10 13:11 ` Karsten Keil
2007-06-10 13:14 ` Jan-Benedict Glaw [this message]
2007-06-11 9:20 ` Andi Drebes
2007-06-11 12:25 ` [KJ] " Darren Jenkins
2007-06-11 17:47 ` Karsten Keil
2007-06-11 18:53 ` Andi Drebes
2007-06-11 18:59 ` Jan-Benedict Glaw
2007-06-11 18:51 ` Andi Drebes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070610131402.GR2649@lug-owl.de \
--to=jbglaw@lug-owl.de \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists-receive@programmierforen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox