From: Andrew Morton <akpm@linux-foundation.org>
To: "Dan Williams" <dan.j.williams@intel.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
"Jan Engelhardt" <jengelh@linux01.gwdg.de>,
"Mariusz Kozlowski" <m.kozlowski@tuxland.pl>,
linux-kernel@vger.kernel.org, "Neil Brown" <neilb@suse.de>,
"Leech, Christopher" <christopher.leech@intel.com>,
"Jeff Garzik" <jeff@garzik.org>,
davem@davemloft.net, "Wolfgang Denk" <wd@denx.de>
Subject: Re: 2.6.22-rc4-mm1
Date: Sun, 10 Jun 2007 23:26:59 -0700 [thread overview]
Message-ID: <20070610232659.ceff247c.akpm@linux-foundation.org> (raw)
In-Reply-To: <e9c3a7c20706102201y536de24ft2daf8fbed066e28f@mail.gmail.com>
On Sun, 10 Jun 2007 22:01:34 -0700 "Dan Williams" <dan.j.williams@intel.com> wrote:
> It would be very helpful to have a clear merge path for dmaengine
> changes and the async offload api.
Yes, this needs some attention.
I'd suggest that you prepare a standalone tree for Linus to pull and we aim at
asking him to pull that for 2.6.23-rc1.
In the meanwhile I'd suggest that you get the core patch(es) out
onto the relevant lists again and cc'ed to the relevant maintainers.
Of course, good changelogging and commenting makes the review a) more
effective, b) more likely to happen and c) less work for reviewers. The
changelog you have for 7556477664edcbe1c9a2fdf60edddfd8455d198b is nice,
but it's awfully short for a 1/4MB patch. It tells us at a high level what
the code does, but it has nothing to say about how it does it: a high-level
design description, of you will.
Put yourself in the position of an experienced kernel developer who doesn't
know this code, and who doesn't know the hardware. What can you do to make
their review easier and more effective?
So. Please have a think about what you can do there, and also see what can
be done about the 312 warnings which
perl scripts/checkpatch.pl patches/git-md-accel.patch
emits. Then send 'em all out again (say, a week from now) and let's all just dig
in and make this thing happen?
next prev parent reply other threads:[~2007-06-11 6:28 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 9:07 2.6.22-rc4-mm1 Andrew Morton
2007-06-06 11:39 ` 2.6.22-rc4-mm1 Gabriel C
2007-06-06 16:51 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-07 0:01 ` 2.6.22-rc4-mm1 Robert Hancock
2007-06-06 12:43 ` 2.6.22-rc4-mm1 Cedric Le Goater
2007-06-06 15:18 ` 2.6.22-rc4-mm1 Michal Piotrowski
2007-06-06 16:01 ` 2.6.22-rc4-mm1 Cedric Le Goater
2007-06-06 16:26 ` 2.6.22-rc4-mm1 Mel Gorman
2007-06-06 16:35 ` 2.6.22-rc4-mm1 William Lee Irwin III
2007-06-06 16:47 ` 2.6.22-rc4-mm1 Mel Gorman
2007-06-06 16:53 ` 2.6.22-rc4-mm1 Cedric Le Goater
2007-06-06 17:20 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-06 17:06 ` 2.6.22-rc4-mm1 Peter Zijlstra
2007-06-06 19:27 ` 2.6.22-rc4-mm1 Peter Zijlstra
2007-06-06 13:04 ` 2.6.22-rc4-mm1 Jiri Slaby
2007-06-06 13:06 ` 2.6.22-rc4-mm1 Cedric Le Goater
2007-06-06 13:48 ` 2.6.22-rc4-mm1 Andy Whitcroft
2007-06-06 17:23 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-06 13:49 ` 2.6.22-rc4-mm1 -- ia64 build failure Andy Whitcroft
2007-06-06 17:43 ` Andrew Morton
2007-06-06 18:11 ` Yinghai Lu
2007-06-06 14:00 ` 2.6.22-rc4-mm1 -- x86_64 ACPI panic Andy Whitcroft
2007-06-06 17:52 ` Andrew Morton
2007-06-08 9:15 ` Luming Yu
2007-06-08 18:12 ` Andrew Morton
2007-06-26 6:00 ` Len Brown
[not found] ` <6bffcb0e0706060356y3628e26m49fdce4d6fb8cac9@mail.gmail.com>
2007-06-06 14:34 ` 2.6.22-rc4-mm1 Michal Piotrowski
2007-06-06 17:14 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-06 16:08 ` 2.6.22-rc4-mm1 - 'lvm vgscan' busticated again Valdis.Kletnieks
2007-06-07 6:44 ` Tejun Heo
2007-06-07 20:28 ` Valdis.Kletnieks
2007-06-08 6:37 ` Tejun Heo
2007-06-06 16:19 ` 2.6.22-rc4-mm1 WANG Cong
2007-06-06 18:09 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-07 2:26 ` 2.6.22-rc4-mm1 WANG Cong
2007-06-07 5:59 ` 2.6.22-rc4-mm1 Matt Mackall
2007-06-07 6:51 ` 2.6.22-rc4-mm1 WANG Cong
2007-06-07 14:04 ` 2.6.22-rc4-mm1 Matt Mackall
2007-06-07 15:40 ` 2.6.22-rc4-mm1 WANG Cong
2007-06-07 15:59 ` 2.6.22-rc4-mm1 Matt Mackall
2007-06-07 16:39 ` 2.6.22-rc4-mm1 WANG Cong
2007-06-07 16:59 ` 2.6.22-rc4-mm1 Matt Mackall
2007-06-08 4:43 ` 2.6.22-rc4-mm1 WANG Cong
2007-06-06 16:30 ` 2.6.22-rc4-mm1 William Lee Irwin III
2007-06-06 18:13 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-06 19:43 ` 2.6.22-rc4-mm1 William Lee Irwin III
2007-06-07 0:32 ` 2.6.22-rc4-mm1 Paul Menage
2007-06-07 1:09 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-07 6:13 ` 2.6.22-rc4-mm1 William Lee Irwin III
2007-06-06 18:23 ` 2.6.22-rc4-mm1 Andy Whitcroft
2007-06-06 16:42 ` 2.6.22-rc4-mm1 Cedric Le Goater
2007-06-06 18:48 ` 2.6.22-rc4-mm1 Michal Piotrowski
2007-06-06 20:16 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-06 22:14 ` 2.6.22-rc4-mm1 Kay Sievers
2007-06-07 8:40 ` 2.6.22-rc4-mm1 Michal Piotrowski
2007-06-07 8:48 ` 2.6.22-rc4-mm1 Kay Sievers
2007-06-07 9:41 ` 2.6.22-rc4-mm1 Michal Piotrowski
2007-06-07 15:04 ` 2.6.22-rc4-mm1 Kay Sievers
2007-06-07 15:25 ` 2.6.22-rc4-mm1 Peter Jones
2007-06-07 15:43 ` 2.6.22-rc4-mm1 Greg KH
2007-06-07 15:52 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-07 15:59 ` 2.6.22-rc4-mm1 Greg KH
2007-06-07 16:06 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-07 16:15 ` 2.6.22-rc4-mm1 Greg KH
2007-06-07 18:48 ` 2.6.22-rc4-mm1 Bill Nottingham
2007-06-07 20:01 ` 2.6.22-rc4-mm1 Greg KH
2007-06-07 21:00 ` 2.6.22-rc4-mm1 Peter Jones
2007-06-07 23:09 ` 2.6.22-rc4-mm1 Greg KH
2007-06-07 22:32 ` 2.6.22-rc4-mm1 Alan Cox
2007-06-07 23:09 ` 2.6.22-rc4-mm1 Greg KH
2007-06-08 15:33 ` 2.6.22-rc4-mm1 Valdis.Kletnieks
2007-06-08 15:50 ` 2.6.22-rc4-mm1 Greg KH
2007-06-08 16:11 ` 2.6.22-rc4-mm1 Greg KH
2007-06-08 16:10 ` 2.6.22-rc4-mm1 Kay Sievers
2007-06-08 7:31 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-08 15:51 ` 2.6.22-rc4-mm1 Greg KH
2007-06-08 16:36 ` 2.6.22-rc4-mm1 Kay Sievers
2007-06-08 17:21 ` 2.6.22-rc4-mm1 Peter Jones
2007-06-06 19:32 ` 2.6.22-rc4-mm1 Mariusz Kozlowski
2007-06-06 20:24 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-06 20:52 ` 2.6.22-rc4-mm1 Fabio Comolli
2007-06-06 21:28 ` 2.6.22-rc4-mm1 Herbert Xu
2007-06-06 23:42 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-07 6:54 ` 2.6.22-rc4-mm1 Jan Engelhardt
2007-06-07 7:01 ` 2.6.22-rc4-mm1 Herbert Xu
2007-06-07 7:12 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-11 5:01 ` 2.6.22-rc4-mm1 Dan Williams
2007-06-11 6:26 ` Andrew Morton [this message]
2007-06-11 6:51 ` 2.6.22-rc4-mm1 Paul Mundt
2007-06-07 19:27 ` 2.6.22-rc4-mm1 Adrian Bunk
2007-06-06 20:58 ` 2.6.22-rc4-mm1 Grant Wilson
2007-06-06 23:37 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-07 14:53 ` 2.6.22-rc4-mm1 Alan Stern
2007-06-08 4:23 ` [linux-usb-devel] 2.6.22-rc4-mm1 Greg KH
2007-06-08 14:06 ` Alan Stern
2007-06-08 18:47 ` Greg KH
2007-06-07 7:53 ` [2.6.22-rc4-mm1] ACPI Exception (processor_throttling) Maciej Rutecki
2007-06-07 8:51 ` Maciej Rutecki
2007-06-07 9:09 ` Luming Yu
2007-06-07 10:30 ` Maciej Rutecki
2007-06-07 12:47 ` 2.6.22-rc4-mm1 KAMEZAWA Hiroyuki
2007-06-07 15:34 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-08 0:31 ` 2.6.22-rc4-mm1 KAMEZAWA Hiroyuki
-- strict thread matches above, loose matches on Subject: below --
2007-06-06 14:21 2.6.22-rc4-mm1 Mikael Pettersson
2007-06-06 15:34 ` 2.6.22-rc4-mm1 Jiri Slaby
2007-06-06 17:56 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-06 18:24 ` 2.6.22-rc4-mm1 Jiri Slaby
2007-06-07 6:44 ` 2.6.22-rc4-mm1 Tejun Heo
2007-06-07 7:01 ` 2.6.22-rc4-mm1 Jiri Slaby
2007-06-07 7:09 ` 2.6.22-rc4-mm1 Tejun Heo
2007-06-07 7:15 ` 2.6.22-rc4-mm1 Jiri Slaby
2007-06-07 7:22 ` 2.6.22-rc4-mm1 Tejun Heo
2007-06-07 15:54 ` 2.6.22-rc4-mm1 Jiri Slaby
2007-06-07 16:01 ` 2.6.22-rc4-mm1 Greg KH
2007-06-07 17:02 ` 2.6.22-rc4-mm1 Jiri Slaby
2007-06-07 20:09 ` 2.6.22-rc4-mm1 Greg KH
[not found] <fa.463099pz3wyAW1RRKsHFuX299RE@ifi.uio.no>
[not found] ` <fa.zIhbKpmFY9tR8ro0OTwpTvD79Xk@ifi.uio.no>
2007-06-06 14:35 ` 2.6.22-rc4-mm1 Robert Hancock
2007-06-06 18:18 ` 2.6.22-rc4-mm1 Andy Whitcroft
2007-06-06 18:27 ` 2.6.22-rc4-mm1 Andrew Morton
2007-06-06 19:06 ` 2.6.22-rc4-mm1 Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070610232659.ceff247c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=christopher.leech@intel.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=neilb@suse.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox