From: Dave Jones <davej@redhat.com>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
gregkh@suse.de
Subject: Re: [PATCH 2/2] [RFC] PCI: Change all drivers to use pci_device->revision
Date: Mon, 11 Jun 2007 11:19:44 -0400 [thread overview]
Message-ID: <20070611151944.GH9174@redhat.com> (raw)
In-Reply-To: <20070608224636.31777.17302.stgit@localhost.localdomain>
On Fri, Jun 08, 2007 at 03:46:36PM -0700, Auke Kok wrote:
> Instead of all drivers reading pci config space to get the revision
> ID, they can now use the pci_device->revision member.
>
> This exposes some issues where drivers where reading a word or a dword
> for the revision number, and adding useless error-handling around the
> read. Some drivers even just read it for no purpose of all.
>
> In devices where the revision ID is being copied over and used in what
> appears to be the equivalent of hotpath, I have left the copy code
> and the cached copy as not to influence the driver's performance.
>
> Compile tested with make all{yes,mod}config on x86_64 and i386.
>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
ACKed-by: Dave Jones <davej@redhat.com>
for the cpufreq bits.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-06-11 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 22:46 [PATCH 1/2] [RFC] PCI: read revision ID by default Auke Kok
2007-06-08 22:46 ` [PATCH 2/2] [RFC] PCI: Change all drivers to use pci_device->revision Auke Kok
2007-06-11 15:19 ` Dave Jones [this message]
2007-06-09 6:59 ` [PATCH 1/2] [RFC] PCI: read revision ID by default Grant Grundler
2007-06-09 8:02 ` David Miller
2007-06-09 19:31 ` Kok, Auke
2007-06-09 19:48 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070611151944.GH9174@redhat.com \
--to=davej@redhat.com \
--cc=auke-jan.h.kok@intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox