From: Dave Jones <davej@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: dougthompson@xmission.com, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 4/6] include linux pci_id-h add amd northbridge defines
Date: Mon, 11 Jun 2007 23:25:53 -0400 [thread overview]
Message-ID: <20070612032553.GB19293@redhat.com> (raw)
In-Reply-To: <20070611234947.GA20078@kroah.com>
On Mon, Jun 11, 2007 at 04:49:47PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Jun 11, 2007 at 04:30:11PM -0700, Doug Thompson wrote:
> > I am working with the k8 driver and its dealing with a race with the mcelog device as both access
> > the K8 NB. The K8 driver does use these regs and it currently has #ifndef s in it for both of
> > them.
> >
> > I guess I could have submitted the patch when the K8 driver was submitted.
>
> That would be preferable, thanks.
Even better (IMO), if they're not used by any other driver (which seems
to be the case), keep the defines local to the driver.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-06-12 3:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 16:45 [PATCH 4/6] include linux pci_id-h add amd northbridge defines dougthompson
2007-06-09 0:08 ` Greg KH
2007-06-11 23:30 ` Doug Thompson
2007-06-11 23:49 ` Greg KH
2007-06-12 3:25 ` Dave Jones [this message]
2007-06-13 5:10 ` Doug Thompson
2007-06-13 12:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612032553.GB19293@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dougthompson@xmission.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox