From: Wang Zhenyu <zhenyu.z.wang@intel.com>
To: Dave Jones <davej@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
andi@rhlx01.fht-esslingen.de, Keith Packard <keithp@keithp.com>
Subject: Re: [RFC][AGPGART]intel-agp: save whole config space in suspend/resume
Date: Tue, 12 Jun 2007 11:34:25 +0800 [thread overview]
Message-ID: <20070612033424.GA30200@zhen-devel.sh.intel.com> (raw)
In-Reply-To: <20070612022320.GA2125@redhat.com>
On 2007.06.11 22:23:21 +0000, Dave Jones wrote:
>
> I'd feel much safer if we only did this on chipsets where we know we
> have to do it. Doing this for *every* Intel chipset ever made _will_
> bite us. There are some early chipsets (440BX era iirc) that would just
> hang the box when you tried to read from various write-only registers.
>
> But even on the chipsets where we _do_ need to save/restore something in
> the upper part of the config space, surely it'd be a lot safer
> to just save/restore what we need to rather than risk all sorts
> of mayhem by writing to bits that may trigger hardware events.
>
I understand. Before James reported his problem on i915, I have thought
the basic restore on that chip should already be enough, but he proved I was
wrong and I'm not sure if this also happens on other i915 board with different
BIOS.
And with my patch it has already removed the restore cases for 440BX like type,
coz it's gmch_chip_id == 0 and intel_private.pcidev is NULL, so it won't save
extra space on those chips.
next prev parent reply other threads:[~2007-06-12 3:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 1:54 [RFC][AGPGART]intel-agp: save whole config space in suspend/resume Wang Zhenyu
2007-06-12 2:23 ` Dave Jones
2007-06-12 3:34 ` Wang Zhenyu [this message]
2007-06-12 3:59 ` Dave Jones
2007-06-12 17:24 ` Jesse Barnes
2007-06-12 9:14 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612033424.GA30200@zhen-devel.sh.intel.com \
--to=zhenyu.z.wang@intel.com \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=davej@redhat.com \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox