public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Dave Jones <davej@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	andi@rhlx01.fht-esslingen.de, Keith Packard <keithp@keithp.com>
Subject: Re: [RFC][AGPGART]intel-agp: save whole config space in suspend/resume
Date: Tue, 12 Jun 2007 10:14:27 +0100	[thread overview]
Message-ID: <20070612091427.GB9719@srcf.ucam.org> (raw)
In-Reply-To: <20070612015459.GB28668@zhen-devel.sh.intel.com>

On Tue, Jun 12, 2007 at 09:54:59AM +0800, Wang Zhenyu wrote:

> +		for (i = 0; i < 48; i++) {

You seem to be writing the base address after the aperture size? That 
won't work. As Dave says, there are ordering contraints.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

      parent reply	other threads:[~2007-06-12  9:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-12  1:54 [RFC][AGPGART]intel-agp: save whole config space in suspend/resume Wang Zhenyu
2007-06-12  2:23 ` Dave Jones
2007-06-12  3:34   ` Wang Zhenyu
2007-06-12  3:59     ` Dave Jones
2007-06-12 17:24       ` Jesse Barnes
2007-06-12  9:14 ` Matthew Garrett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070612091427.GB9719@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=andi@rhlx01.fht-esslingen.de \
    --cc=davej@redhat.com \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox