public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Hans de Goede <j.w.r.degoede@hhs.nl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Stanislav Brabec <sbrabec@suse.cz>
Subject: Re: Proposal: change keycode for scancode e0 32 from 150 to 172
Date: Wed, 13 Jun 2007 12:38:06 +0200	[thread overview]
Message-ID: <20070613103806.GF19888@suse.cz> (raw)
In-Reply-To: <466F1E5C.5090002@zytor.com>

On Tue, Jun 12, 2007 at 03:29:48PM -0700, H. Peter Anvin wrote:
> I just tested this using Microsoft Natural Keyboard Pro, which is a
> dual-mode (USB-PS/2) keyboard.
> 
> This key is labelled Web/Home and has a picture of a house on the keycap.
> 
> In PS/2 mode it reports E0 32 which gets converted to keycode 150.
> In USB mode it reports E0 02 which gets converted to keycode 172.
> 
> I don't know if it's the keyboard itself that's being inconsistent, or
> if it is the table in usbkbd.c that's broken (in which case it should be
> fixed to be consistent with the keyboard in PS/2 mode.)

USB keyboards don't send scancodes, what you see is smoke and mirrors.

Yes, the atkbd.c and hid-input.c mappings are inconsistent. We probably
want to fix atkbd.c (scancode->keycode mapping), and maybe also
char/keyboard.c (keycode->synth scancode mapping).

> > The logo on the key is a homepage logo, the text below is www/homepage.
> > So what to send? I believe that for consistency with the usb codes send
> > it should be KEY_HOMEPAGE, but thats based on a sample of 1 usb
> > keyboard. Input on what other usb keyboards send for the key with the
> > homepage iocn is very much welcome.
> 
> You seem to be of the opinion that "usb behaviour is correct", but don't
> give any motivation why usb should take precedence.  Offhand, I would
> expect there to be fewer translation layers for PS/2 and would therefore
> assume PS/2 is more inherently correct.

KEY_HOMEPAGE seems to better fit the description of how the key looks.
Microsoft calls it "WWW Home", and it's supposed to be e0 32. 

-- 
Vojtech Pavlik
Director SuSE Labs

  parent reply	other threads:[~2007-06-13 10:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-12 21:47 Proposal: change keycode for scancode e0 32 from 150 to 172 Hans de Goede
2007-06-12 22:29 ` H. Peter Anvin
2007-06-13  6:06   ` Hans de Goede
2007-06-13  9:18   ` Jiri Kosina
2007-06-13  9:25     ` Hans de Goede
2007-06-13  9:32       ` Jiri Kosina
2007-06-13 13:45         ` Dmitry Torokhov
2007-06-18 22:59           ` PATCH: " Hans de Goede
2007-06-19 13:44             ` Vojtech Pavlik
2007-06-13 13:02       ` Proposal: " Vojtech Pavlik
2007-06-13 10:38   ` Vojtech Pavlik [this message]
2007-06-14 12:35     ` Stanislav Brabec
2007-06-13 10:29 ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070613103806.GF19888@suse.cz \
    --to=vojtech@suse.cz \
    --cc=hpa@zytor.com \
    --cc=j.w.r.degoede@hhs.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sbrabec@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox