Re: I815 suddenly unkown to agpgart?

Dave Jones
2007-06-14T22:15:45Z

On Thu, Jun 14, 2007 at 10:01:04AM +0800, Wang Zhenyu wrote:
> On 2007.06.14 09:34:12 +0000, Wang Zhenyu wrote:
> >
> > Dave, after rethinking about this, I think we mixed two cases
> > need to be fixed here. This is the patch for this, sorry for mess
> > it up. Meelis, could you help to test by replace my last patch with this?
> >
>
> oop, for 945GME like case, we should stop scan if still no detection.
> Updated patch here.
>
> [AGPGART] intel_agp: fix device probe
>
> This patch trys to fix device probe in two cases. First we should
> correctly detect device if integrated graphics device is not enabled
> or exists, like an add-in card is plugged. Second on some type of intel
> GMCH, it might have multiple graphic chip models, like 945GME case, so
> we should be sure the detect works through the whole table.

Applied, though next time, be careful with whitespace..

$ git-applymbox -k ~/agp
1 patch(es) to process.

Applying '[AGPGART] intel_agp: fix device probe'

Adds trailing whitespace.
.dotest/patch:127: bridge->driver =
Space in indent is followed by a tab.
.dotest/patch:133: bridge->driver = intel_agp_chipsets[i].driver;
warning: 2 lines add trailing whitespaces.

I fixed it up this time.

Dave

--