From: Wang Zhenyu <zhen78@gmail.com>
To: Dave Jones <davej@redhat.com>, Meelis Roos <mroos@linux.ee>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Wang Zhenyu <zhenyu.z.wang@intel.com>,
Eric Anholt <eric@anholt.net>
Subject: Re: I815 suddenly unkown to agpgart?
Date: Thu, 14 Jun 2007 02:00:39 +0800 [thread overview]
Message-ID: <20070613180039.GA4508@localhost.localdomain> (raw)
In-Reply-To: <20070613161513.GE3875@redhat.com>
On 2007.06.13 12:15:13 +0000, Dave Jones wrote:
> > [AGPGART] intel_agp: use table for device probe
> >
> Oh, we have this check in find_gmch ..
>
> if (gmch_device && PCI_FUNC(gmch_device->devfn) != 0) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Which isn't going to work, as Meelis has a gmch on device0, slot0, devfn1.
> Meelis, does it start working again if you change that to just
>
> if (gmch_Device) {
No, the problem for i815 is that it has a config with no integrated gfx.
Sorry I missed it. Meelis, pls test with this patch, which adds a table
item for this, and fixes wrong driver order within origin i815 driver with IGD.
Thanks.
---
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index d383168..6d50a37 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -1824,7 +1824,8 @@ static const struct intel_driver_description {
{ PCI_DEVICE_ID_INTEL_82810E_MC, PCI_DEVICE_ID_INTEL_82810E_IG, "i810",
NULL, &intel_810_driver },
{ PCI_DEVICE_ID_INTEL_82815_MC, PCI_DEVICE_ID_INTEL_82815_CGC, "i815",
- &intel_810_driver, &intel_815_driver },
+ &intel_815_driver, &intel_810_driver },
+ { PCI_DEVICE_ID_INTEL_82815_MC, 0, "i815", &intel_815_driver, NULL },
{ PCI_DEVICE_ID_INTEL_82820_HB, 0, "i820", &intel_820_driver, NULL },
{ PCI_DEVICE_ID_INTEL_82820_UP_HB, 0, "i820", &intel_820_driver, NULL },
{ PCI_DEVICE_ID_INTEL_82830_HB, PCI_DEVICE_ID_INTEL_82830_CGC, "830M",
---
next prev parent reply other threads:[~2007-06-13 17:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 15:07 I815 suddenly unkown to agpgart? Meelis Roos
2007-06-13 16:01 ` Dave Jones
2007-06-13 16:15 ` Dave Jones
2007-06-13 17:59 ` Meelis Roos
2007-06-13 18:00 ` Wang Zhenyu [this message]
2007-06-13 18:19 ` Meelis Roos
2007-06-13 18:22 ` Dave Jones
2007-06-14 1:34 ` Wang Zhenyu
2007-06-14 2:01 ` Wang Zhenyu
2007-06-14 6:03 ` Meelis Roos
2007-06-14 22:09 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070613180039.GA4508@localhost.localdomain \
--to=zhen78@gmail.com \
--cc=davej@redhat.com \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox