From: Andi Drebes <lists-receive@programmierforen.de>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Christoph Hellwig <hch@infradead.org>,
Len Brown <lenb@kernel.org>,
kernel-janitors@lists.osdl.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE
Date: Wed, 13 Jun 2007 23:21:38 +0200 [thread overview]
Message-ID: <200706132321.39440.lists-receive@programmierforen.de> (raw)
In-Reply-To: <200706121253.07395.bjorn.helgaas@hp.com>
<snip>
> You found the right one. The ACPI CA in Linux is really the same
> as the one from Intel. Len integrates the Intel one into Linux
> periodically. He uses scripts or something to format it so it looks
> more like Linux.
Ok. That's what I thought so far.
> I think Len sometimes takes patches against the "Linux-ized" ACPI CA.
> He probably has to apply those by hand to the Intel one, which is
> the real "upstream" in this case. So it might be a bit easier for
> him if you generated a diff against the Intel version.
OK. I will do this in the next time.
> In any event, you want to end up with one patch, not two.
Ok. I thought of two patches because I didn't know how strong
the sources from the ACPI CA are modified.
> You probably would have to add something like:
>
> #ifndef ARRAY_SIZE
> #define ARRAY_SIZE(x) ...
> #endif
>
> somewhere in the ACPI CA header files. That way it will work in
> non-Linux OSes as well.
Thanks so far,
Andi
next prev parent reply other threads:[~2007-06-13 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200705261239.27485.lists-receive@programmierforen.de>
[not found] ` <46581C06.7000005@student.ltu.se>
[not found] ` <200705261558.24912.lists-receive@programmierforen.de>
[not found] ` <200705301525.05905.lenb@kernel.org>
2007-05-31 9:56 ` [KJ] [PATCH] drivers/acpi: sizeof/sizeof array size calculations replaced with ARRAY_SIZE Christoph Hellwig
2007-06-10 10:57 ` Pavel Machek
2007-06-10 21:44 ` Bjorn Helgaas
2007-06-12 18:41 ` Andi Drebes
2007-06-12 18:53 ` Bjorn Helgaas
2007-06-13 21:21 ` Andi Drebes [this message]
2007-06-15 17:56 ` Andi Drebes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706132321.39440.lists-receive@programmierforen.de \
--to=lists-receive@programmierforen.de \
--cc=bjorn.helgaas@hp.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox