* [PATCH] i2c-gpio: Make some internal functions static
@ 2007-06-12 15:54 Atsushi Nemoto
2007-06-13 11:16 ` Haavard Skinnemoen
0 siblings, 1 reply; 3+ messages in thread
From: Atsushi Nemoto @ 2007-06-12 15:54 UTC (permalink / raw)
To: Haavard Skinnemoen; +Cc: linux-kernel, i2c, khali
i2c_gpio_getsda() and i2c_gpio_getscl() are only used in this file.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index a7dd546..ca74092 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++ b/drivers/i2c/busses/i2c-gpio.c
@@ -63,14 +63,14 @@ static void i2c_gpio_setscl_val(void *data, int state)
gpio_set_value(pdata->scl_pin, state);
}
-int i2c_gpio_getsda(void *data)
+static int i2c_gpio_getsda(void *data)
{
struct i2c_gpio_platform_data *pdata = data;
return gpio_get_value(pdata->sda_pin);
}
-int i2c_gpio_getscl(void *data)
+static int i2c_gpio_getscl(void *data)
{
struct i2c_gpio_platform_data *pdata = data;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c-gpio: Make some internal functions static
2007-06-12 15:54 [PATCH] i2c-gpio: Make some internal functions static Atsushi Nemoto
@ 2007-06-13 11:16 ` Haavard Skinnemoen
2007-06-14 6:33 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Haavard Skinnemoen @ 2007-06-13 11:16 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-kernel, i2c, khali
On Wed, 13 Jun 2007 00:54:38 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> i2c_gpio_getsda() and i2c_gpio_getscl() are only used in this file.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Ah, of course. Hopefully this is the last remaining sign that the
driver started out as a quick hack :-)
Acked-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c-gpio: Make some internal functions static
2007-06-13 11:16 ` Haavard Skinnemoen
@ 2007-06-14 6:33 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2007-06-14 6:33 UTC (permalink / raw)
To: Haavard Skinnemoen; +Cc: Atsushi Nemoto, linux-kernel, i2c
On Wed, 13 Jun 2007 13:16:41 +0200, Haavard Skinnemoen wrote:
> On Wed, 13 Jun 2007 00:54:38 +0900 (JST)
> Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
>
> > i2c_gpio_getsda() and i2c_gpio_getscl() are only used in this file.
> >
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>
> Ah, of course. Hopefully this is the last remaining sign that the
> driver started out as a quick hack :-)
>
> Acked-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
Correct. Applied, thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-06-14 6:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-12 15:54 [PATCH] i2c-gpio: Make some internal functions static Atsushi Nemoto
2007-06-13 11:16 ` Haavard Skinnemoen
2007-06-14 6:33 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox