Re: [PATCH] driver core: multithreaded device matching with dependency

[Greg KH <greg@kroah.com>]

On Tue, Jun 12, 2007 at 04:30:57PM +0200, Stefan Richter wrote:
> 
> There is so much unskilled labor in driver hacking land (I'm merely
> speaking for myself of course) that something like the driver core
> /really/ needs well-working, easy to understand, and well-documented APIs.
> 
> PS:  By a well-documented struct definition I mean:
>    - Public members have a type and name which indicate the meaning of
>      the member, and there is a comment on permissible or required
>      write/read accesses to the member.
>    - Private members are undocumented or even better yet explicitly
>      marked as private.

We are slowly working toward this goal with the cleanups and work that
Kay has been doing over the past year.  So be patient, it is slowly
coming, or please help out if you can.

> If the access methods to public members turn out too difficult and
> fragile, make the members private and provide documented public accessors.

Well, let's not get into the whole "accessors are good/evil" type thread
here, but yes, we'll work to try to make this whole thing easier to use
and very hard to use incorrectly (which is not true today, I know,
sorry...)

thanks,

greg k-h