public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Wang Zhenyu <zhen78@gmail.com>, Meelis Roos <mroos@linux.ee>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Eric Anholt <eric@anholt.net>
Subject: Re: I815 suddenly unkown to agpgart?
Date: Thu, 14 Jun 2007 18:09:24 -0400	[thread overview]
Message-ID: <20070614220924.GA8555@redhat.com> (raw)
In-Reply-To: <20070614020104.GB31534@zhen-devel.sh.intel.com>

On Thu, Jun 14, 2007 at 10:01:04AM +0800, Wang Zhenyu wrote:
 > On 2007.06.14 09:34:12 +0000, Wang Zhenyu wrote:
 > > 
 > > Dave, after rethinking about this, I think we mixed two cases 
 > > need to be fixed here. This is the patch for this, sorry for mess
 > > it up. Meelis, could you help to test by replace my last patch with this? 
 > > 
 > 
 > oop, for 945GME like case, we should stop scan if still no detection. 
 > Updated patch here. 
 > 
 > [AGPGART] intel_agp: fix device probe
 > 
 > This patch trys to fix device probe in two cases. First we should
 > correctly detect device if integrated graphics device is not enabled
 > or exists, like an add-in card is plugged. Second on some type of intel
 > GMCH, it might have multiple graphic chip models, like 945GME case, so
 > we should be sure the detect works through the whole table.

Applied, though next time, be careful with whitespace..

$ git-applymbox -k ~/agp
1 patch(es) to process.

Applying '[AGPGART] intel_agp: fix device probe'

Adds trailing whitespace.
.dotest/patch:127:                              bridge->driver = 
Space in indent is followed by a tab.
.dotest/patch:133:                              bridge->driver = intel_agp_chipsets[i].driver;
warning: 2 lines add trailing whitespaces.


I fixed it up this time.

	Dave

-- 
http://www.codemonkey.org.uk

      parent reply	other threads:[~2007-06-14 22:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 15:07 I815 suddenly unkown to agpgart? Meelis Roos
2007-06-13 16:01 ` Dave Jones
2007-06-13 16:15   ` Dave Jones
2007-06-13 17:59     ` Meelis Roos
2007-06-13 18:00     ` Wang Zhenyu
2007-06-13 18:19       ` Meelis Roos
2007-06-13 18:22       ` Dave Jones
2007-06-14  1:34         ` Wang Zhenyu
2007-06-14  2:01           ` Wang Zhenyu
2007-06-14  6:03             ` Meelis Roos
2007-06-14 22:09             ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070614220924.GA8555@redhat.com \
    --to=davej@redhat.com \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=zhen78@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox