Re: [patch 4/8] 2.6.22-rc3 perfmon2 : IBS implementation for AMD64

Robert Richter
2007-06-20T18:46:33Z

David,

> Please don't include mixed cases of hex digits. This entire file has all
> hex digits in lowercase type, so please conform to that.

I fixed this in the 2nd version of the patch.

> > +#define K8_MTRRFIXRANGE_DRAM_ENABLE 0x00040000 /* MtrrFixDramEn bit */
> > +#define K8_MTRRFIXRANGE_DRAM_MODIFY 0x00080000 /* MtrrFixDramModEn bit */
> > +#define K8_MTRR_RDMEM_WRMEM_MASK 0x18181818 /* Mask: RdMem|WrMem */
>
> Masks like K8_MTRR_RDMEM_WRMEM_MASK are prone to bugs when the values they
> are testing change and somebody forgets to update the mask. Can you make
> K8_MTRR_RDMEM_WRMEM_MASK defined to be the result of another preprocessor
> macro expression? Or, even better, get rid of it completely and modify
> set_fixed_range()?

This is existing code, won't change that.

Thanks,
-Robert