From: Arnd Bergmann <arnd@arndb.de>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: akpm@linux-foundation.org, vtaras@openvz.org, dev@sw.ru,
devel@openvz.org, jack@suse.cz, linux-kernel@vger.kernel.org,
nataliep@google.com, vvs@sw.ru
Subject: Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures
Date: Fri, 15 Jun 2007 12:43:01 +0200 [thread overview]
Message-ID: <200706151243.02186.arnd@arndb.de> (raw)
In-Reply-To: <200706151003.l5FA3vd6008194@harpo.it.uu.se>
On Friday 15 June 2007, Mikael Pettersson wrote:
> > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig 2007-06-14 15:55:26.000000000 +0400
> > +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.000000000 +0400
> ...
> > +#if defined(CONFIG_X86_64) || defined(CONFIG_IA64)
> > +/*
> > + * This code works only for 32 bit quota tools over 64 bit OS (x86_64, ia64)
> > + * and is necessary due to alignment problems.
> > + */
>
> The #ifdef looks way too arch-specific. And isn't there a shared
> compat.c module somewhere that this should go into?
>
Only x86_64 and ia64 have this particular problem, the other architectures,
and hopefully all future 64 bit platforms with 32 bit user space use
the same alignment rules in elf32 and elf64.
Still, the patch should be converted to use the compat_u64 type and not
add an 'attribute((packed))' so that you _can_ use the same code on all
architectures. See my 'Introduce compat_u64 and compat_s64 types' patch
that I just posted in another thread.
Arnd <><
next prev parent reply other threads:[~2007-06-15 10:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 10:03 [PATCH] diskquota: 32bit quota tools on 64bit architectures Mikael Pettersson
2007-06-15 10:41 ` Vasily Tarasov
2007-06-15 10:43 ` Arnd Bergmann [this message]
2007-06-15 11:00 ` Vasily Tarasov
2007-06-15 14:48 ` Vasily Tarasov
2007-06-15 15:24 ` Arnd Bergmann
2007-06-18 7:41 ` Vasily Tarasov
-- strict thread matches above, loose matches on Subject: below --
2007-06-18 8:21 Vasily Tarasov
2007-06-19 19:33 ` Andrew Morton
2007-06-19 20:09 ` Mikael Pettersson
2007-06-19 22:34 ` David Miller
2007-06-15 11:08 Mikael Pettersson
2007-06-15 9:01 Vasily Tarasov
2007-06-15 8:59 Vasily Tarasov
2006-10-25 10:03 Vasily Tarasov
2006-10-25 11:03 ` Arnd Bergmann
2006-10-25 11:25 ` Vasily Tarasov
2006-10-25 11:50 ` Arnd Bergmann
2006-10-20 5:59 Vasily Tarasov
2006-10-19 12:32 Vasily Tarasov
2006-10-19 13:06 ` Alan Cox
2006-10-19 15:22 ` Randy Dunlap
2006-10-19 16:09 ` Andi Kleen
2006-10-20 6:30 ` Vasily Tarasov
2006-10-20 7:12 ` Christoph Hellwig
2006-10-20 12:21 ` Andi Kleen
2006-10-19 17:29 ` Christoph Hellwig
2006-10-20 6:10 ` Vasily Tarasov
2006-10-21 16:28 ` Arnd Bergmann
2006-10-23 2:12 ` David Chinner
2006-10-23 10:51 ` Vasily Tarasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706151243.02186.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=dev@sw.ru \
--cc=devel@openvz.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=nataliep@google.com \
--cc=vtaras@openvz.org \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox