From: Dmitriy Monakhov <dmonakhov@sw.ru>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel@vger.kernel.org, npiggin@suse.de,
mark.fasheh@oracle.com, linux-ext4@vger.kernel.org
Subject: [PATCH] deny partial write for loop dev fd
Date: Sat, 16 Jun 2007 19:39:17 +0400 [thread overview]
Message-ID: <20070616153917.GC14349@localhost.sw.ru> (raw)
In-Reply-To: <Pine.LNX.4.64.0706131543380.10580@blonde.wat.veritas.com>
Partial write can be easily supported by LO_CRYPT_NONE mode, but
it is not easy in LO_CRYPT_CRYPTOAPI case, because of its block nature.
I don't know who still used cryptoapi, but theoretically it is possible.
So let's leave things as they are. Loop device doesn't support partial
write before Nick's "write_begin/write_end" patch set, and let's it
behave the same way after.
Signed-off-by: Dmitriy Monakhov <dmonakhov@openvz.org>
---
drivers/block/loop.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 4bab9b1..de122f3 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -244,10 +244,8 @@ static int do_lo_send_aops(struct loop_device *lo, struct bio_vec *bvec,
ret = pagecache_write_end(file, mapping, pos, size, copied,
page, fsdata);
- if (ret < 0)
+ if (ret < 0 || ret != copied)
goto fail;
- if (ret < copied)
- copied = ret;
if (unlikely(transfer_result))
goto fail;
--
1.5.2
next prev parent reply other threads:[~2007-06-16 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 13:46 [patch] new aop loop fix Dmitriy Monakhov
2007-06-13 13:36 ` Hugh Dickins
2007-06-13 17:29 ` Dmitriy Monakhov
2007-06-13 14:48 ` Hugh Dickins
2007-06-16 15:39 ` Dmitriy Monakhov [this message]
2007-06-18 2:39 ` [PATCH] deny partial write for loop dev fd Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070616153917.GC14349@localhost.sw.ru \
--to=dmonakhov@sw.ru \
--cc=hugh@veritas.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox