Re: [PATCH] hwmon/coretemp: Fix a broken error path

Jean Delvare
2007-06-18T07:17:28Z

Hi Soeren,

On Sun, 17 Jun 2007 11:16:43 +0200, Soeren Sonnenburg wrote:
> On Sat, 2007-06-16 at 23:17 +0200, Jean Delvare wrote:
> > Thanks for reporting. Indeed this patch is broken, sorry for
> > overlooking it. I tested it but my hardware is such that the faulty
> > error path was never taken. Please test the following patch (on top of
> > git-current) and confirm it fixes your problem:
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Rudolf Marek <r.marek@assembler.cz>
> > ---
> > drivers/hwmon/coretemp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- linux-2.6.22-rc4.orig/drivers/hwmon/coretemp.c 2007-06-05 10:25:54.000000000 +0200
> > +++ linux-2.6.22-rc4/drivers/hwmon/coretemp.c 2007-06-16 23:14:06.000000000 +0200
> > @@ -185,6 +185,7 @@ static int __devinit coretemp_probe(stru
> > /* check for microcode update */
> > rdmsr_on_cpu(data->id, MSR_IA32_UCODE_REV, &eax, &edx);
> > if (edx < 0x39) {
> > + err = -ENODEV;
> > dev_err(&pdev->dev,
> > "Errata AE18 not fixed, update BIOS or "
> > "microcode of the CPU!\n");
>
> this patch indeed fixes the problem. Thanks!

OK, great. Andrew, can you please pick this patch:
http://lkml.org/lkml/2007/6/16/177
and push it to Linus in your next batch?

> Soeren
> --
> Sometimes, there's a moment as you're waking, when you become aware of
> the real world around you, but you're still dreaming.

I too listen to Astral Projection at times :)

Thanks,
--
Jean Delvare