From: Ivan Kuten <ivan.kuten@promwad.com>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: Andrew Victor <andrew@sanpeople.com>,
Russell King <rmk@arm.linux.org.uk>,
Nicolas Ferre <nicolas.ferre@rfo.atmel.com>,
Patrice Vilchez <patrice.vilchez@rfo.atmel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atmel_serial: Fix break handling
Date: Mon, 18 Jun 2007 13:21:21 +0300 [thread overview]
Message-ID: <20070618132121.2d00a907@newbox> (raw)
In-Reply-To: <20070605132336.3b8a9a4e@dhcp-255-175.norway.atmel.com>
On Tue, 5 Jun 2007 13:23:36 +0200
Haavard Skinnemoen wrote:
> On Tue, 5 Jun 2007 14:07:20 +0300
> Ivan Kuten <ivan.kuten@promwad.com> wrote:
>
> > I tried to test your patch on AT91RM9200 with Magic SysRq sequence, unfortunately without
> > success - SysRq still does not work. You mention "break count increments" where do you check it ? I have
> > cat /proc/tty/driver/atmel_serial
> > serinfo:1.0 driver revision:
> > 0: uart:ATMEL_SERIAL mmio:0xFEFFF200 irq:1 tx:8554 rx:623 fe:25 RTS|CTS|DTR|DSR|CD|RI
> > 1: uart:ATMEL_SERIAL mmio:0xFFFC0000 irq:6 tx:0 rx:0 CTS|DSR|CD|RI
> > 2: uart:ATMEL_SERIAL mmio:0xFFFC4000 irq:7 tx:0 rx:0 RI
> > 3: uart:ATMEL_SERIAL mmio:0xFFFC8000 irq:8 tx:0 rx:0 DSR|CD|RI
> > 4: uart:ATMEL_SERIAL mmio:0xFFFCC000 irq:9 tx:0 rx:0 CTS|DSR|CD|RI
> >
> > no any break counter.
>
> Andrew Victor pointed out that the RM9200 DBGU doesn't support break at
> all, and the data sheet seems to agree. The break counter seems to show
> up after the first break has been received and you're probably not
> receiving any.
>
> Is it possible for you to try a different USART as console?
>
> Haavard
Hi Haavard,
I tried /dev/ttyAT3, break appeared but not the way I expected, after: stty -F /dev/ttyAT3 brkint
I get:
cat /proc/tty/driver/atmel_serial
serinfo:1.0 driver revision:
0: uart:ATMEL_SERIAL mmio:0xFEFFF200 irq:1 tx:0 rx:0 CTS|DSR|CD|RI
1: uart:ATMEL_SERIAL mmio:0xFFFC0000 irq:6 tx:0 rx:0 CTS|DSR|CD|RI
2: uart:ATMEL_SERIAL mmio:0xFFFC4000 irq:7 tx:0 rx:0 RI
3: uart:ATMEL_SERIAL mmio:0xFFFC8000 irq:8 tx:1530 rx:115 brk:1 RTS|DTR|DSR|CD|RI
4: uart:ATMEL_SERIAL mmio:0xFFFCC000 irq:9 tx:0 rx:0 DSR|CD|RI
brk is 1 not depending on how many breaks was sent. May be I missunderstood "break" meaning?
I use from minicom: Main Functions : send break.........F .
I inserted printk:
/*
* Control the transmission of a break signal
*/
static void atmel_break_ctl(struct uart_port *port, int break_state)
{
printk(KERN_EMERG "atmel_break_ctl break_state %d", break_state);
if (break_state != 0)
UART_PUT_CR(port, ATMEL_US_STTBRK); /* start break */
else
UART_PUT_CR(port, ATMEL_US_STPBRK); /* stop break */
}
it's also not shown.
BR,
Ivan
next prev parent reply other threads:[~2007-06-18 10:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 19:31 [PATCH] atmel_serial: Fix break handling Haavard Skinnemoen
2007-06-05 11:07 ` Ivan Kuten
2007-06-05 11:23 ` Haavard Skinnemoen
2007-06-18 10:21 ` Ivan Kuten [this message]
2007-06-18 10:33 ` Russell King
2007-06-19 10:36 ` Ivan Kuten
2007-06-19 16:58 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070618132121.2d00a907@newbox \
--to=ivan.kuten@promwad.com \
--cc=andrew@sanpeople.com \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@rfo.atmel.com \
--cc=patrice.vilchez@rfo.atmel.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox