From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
prasanna@in.ibm.com, ananth@in.ibm.com, jkenisto@us.ibm.com
Subject: Re: [patch 1/3] Text Edit Lock - i386
Date: Tue, 19 Jun 2007 01:05:10 +0200 [thread overview]
Message-ID: <200706190105.10803.ak@suse.de> (raw)
In-Reply-To: <46770CA9.4070304@redhat.com>
On Tuesday 19 June 2007 00:52:25 Chuck Ebbert wrote:
> On 06/18/2007 05:58 PM, Mathieu Desnoyers wrote:
> > Interface to use for code patching : uses a mutex to insure mutual edit
> > exclusion and makes sure the page is writable.
> >
> ...
> > +/* Mutex protecting text section modification (dynamic code patching) */
> > +static DEFINE_MUTEX(text_mutex);
> > +
>
> Probably should be a spinlock.
>
> And it just occurred to me, how does smp_alternatives deal with this?
> Is it broken now when the text section is read-only?
The text section is only changed to ro very late, alternative code
runs earlier.
But when you unplug all CPUs to go back to UP I suspect it may break.
-Andi
next prev parent reply other threads:[~2007-06-18 23:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 21:58 [patch 0/3] Text Section Edit Lock Mathieu Desnoyers
2007-06-18 21:58 ` [patch 1/3] Text Edit Lock - i386 Mathieu Desnoyers
2007-06-18 22:52 ` Chuck Ebbert
2007-06-18 23:05 ` Andi Kleen [this message]
2007-06-18 23:05 ` Mathieu Desnoyers
2007-06-18 21:58 ` [patch 2/3] Text Edit Lock - Alternative i386 Mathieu Desnoyers
2007-06-18 21:58 ` [patch 3/3] Text Edit Lock - kprobes i386 Mathieu Desnoyers
-- strict thread matches above, loose matches on Subject: below --
2007-07-03 16:38 [patch 0/3] Text Edit Lock (i386) Mathieu Desnoyers
2007-07-03 16:38 ` [patch 1/3] Text Edit Lock - i386 Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706190105.10803.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=cebbert@redhat.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox