From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Cc: Christoph Lameter <clameter@sgi.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Dinakar Guniguntala <dino@in.ibm.com>,
Dmitry Adamushko <dmitry.adamushko@gmail.com>,
suresh.b.siddha@intel.com, pwil3058@bigpond.net.au,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: v2.6.21.4-rt11
Date: Mon, 18 Jun 2007 19:13:43 -0700 [thread overview]
Message-ID: <20070619021342.GC7160@linux-os.sc.intel.com> (raw)
In-Reply-To: <20070619015232.GE17865@linux.vnet.ibm.com>
On Tue, Jun 19, 2007 at 07:22:32AM +0530, Srivatsa Vaddagiri wrote:
> On Mon, Jun 18, 2007 at 10:59:21AM -0700, Christoph Lameter wrote:
> > I think the check in idle_balance needs to be modified.
> >
> > If the domain *does not* have SD_BALANCE_NEWIDLE set then
> > next_balance must still be set right. Does this patch fix it?
>
> Is the ->next_balance calculation in idle_balance() necessary at all?
> rebalance_domains() would have programmed ->next_balance anyway, based
> on the nearest next_balance point of all (load-balance'able) domains.
> By repeating that calculation in idle_balance, are we covering any corner case?
rebalance_domains() have programmed ->next_balance based on 'busy' state.
And now, as it is going to 'idle', this routine is recalculating
the next_balance based on 'idle' state.
thanks,
suresh
next prev parent reply other threads:[~2007-06-19 2:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070613180451.GA16628@elte.hu>
[not found] ` <20070613184741.GC8125@linux.vnet.ibm.com>
[not found] ` <20070613185522.GA27335@elte.hu>
[not found] ` <20070613233910.GJ8125@linux.vnet.ibm.com>
[not found] ` <20070615144535.GA12078@elte.hu>
[not found] ` <20070615151452.GC9301@linux.vnet.ibm.com>
[not found] ` <20070615195545.GA28872@elte.hu>
[not found] ` <20070616011605.GH9301@linux.vnet.ibm.com>
[not found] ` <20070616084434.GG2559@linux.vnet.ibm.com>
[not found] ` <20070616161213.GA2994@linux.vnet.ibm.com>
2007-06-18 15:12 ` v2.6.21.4-rt11 Srivatsa Vaddagiri
2007-06-18 16:54 ` v2.6.21.4-rt11 Christoph Lameter
2007-06-18 17:35 ` v2.6.21.4-rt11 Srivatsa Vaddagiri
2007-06-18 17:59 ` v2.6.21.4-rt11 Christoph Lameter
2007-06-19 1:52 ` v2.6.21.4-rt11 Srivatsa Vaddagiri
2007-06-19 2:13 ` Siddha, Suresh B [this message]
2007-06-19 2:15 ` v2.6.21.4-rt11 Siddha, Suresh B
2007-06-19 3:46 ` v2.6.21.4-rt11 Christoph Lameter
2007-06-19 5:49 ` v2.6.21.4-rt11 Srivatsa Vaddagiri
2007-06-19 8:07 ` v2.6.21.4-rt11 Ingo Molnar
2007-06-18 18:06 ` v2.6.21.4-rt11 Srivatsa Vaddagiri
2007-06-19 9:04 ` v2.6.21.4-rt11 Ingo Molnar
2007-06-19 10:43 ` v2.6.21.4-rt11 Srivatsa Vaddagiri
2007-06-19 14:33 ` v2.6.21.4-rt11 Srivatsa Vaddagiri
2007-06-19 19:15 ` v2.6.21.4-rt11 Christoph Lameter
2007-06-19 15:08 ` v2.6.21.4-rt11 Paul E. McKenney
2007-06-19 19:14 ` v2.6.21.4-rt11 Christoph Lameter
2007-06-10 17:50 v2.6.21.4-rt11 Miguel Botón
-- strict thread matches above, loose matches on Subject: below --
2007-06-09 21:05 v2.6.21.4-rt11 Ingo Molnar
2007-06-11 1:19 ` v2.6.21.4-rt11 Paul E. McKenney
2007-06-11 7:36 ` v2.6.21.4-rt11 Ingo Molnar
2007-06-11 14:44 ` v2.6.21.4-rt11 Paul E. McKenney
2007-06-11 15:38 ` v2.6.21.4-rt11 Ingo Molnar
2007-06-11 15:55 ` v2.6.21.4-rt11 Paul E. McKenney
2007-06-11 17:18 ` v2.6.21.4-rt11 Paul E. McKenney
2007-06-11 20:44 ` v2.6.21.4-rt11 Paul E. McKenney
2007-06-11 22:18 ` v2.6.21.4-rt11 Paul E. McKenney
2007-06-12 21:37 ` v2.6.21.4-rt11 Ingo Molnar
2007-06-13 1:27 ` v2.6.21.4-rt11 Paul E. McKenney
2007-06-12 6:03 ` v2.6.21.4-rt11 Eric St-Laurent
2007-06-12 7:32 ` v2.6.21.4-rt11 Ingo Molnar
2007-06-12 13:00 ` v2.6.21.4-rt11 Pallipadi, Venkatesh
2007-06-13 1:37 ` v2.6.21.4-rt11 Eric St-Laurent
2007-06-17 16:15 ` v2.6.21.4-rt11 Nelson Castillo
2007-06-17 16:43 ` v2.6.21.4-rt11 Thomas Gleixner
2007-06-17 16:49 ` v2.6.21.4-rt11 Nelson Castillo
2007-06-17 16:59 ` v2.6.21.4-rt11 Thomas Gleixner
2007-06-18 16:14 ` v2.6.21.4-rt11 Katsuya MATSUBARA
2007-06-19 4:04 ` v2.6.21.4-rt11 Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070619021342.GC7160@linux-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dino@in.ibm.com \
--cc=dmitry.adamushko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pwil3058@bigpond.net.au \
--cc=tglx@linutronix.de \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox