From: Vojtech Pavlik <vojtech@suse.cz>
To: Hans de Goede <j.w.r.degoede@hhs.nl>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@jikos.cz>, "H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stanislav Brabec <sbrabec@suse.cz>
Subject: Re: PATCH: change keycode for scancode e0 32 from 150 to 172
Date: Tue, 19 Jun 2007 15:44:16 +0200 [thread overview]
Message-ID: <20070619134416.GL6382@suse.cz> (raw)
In-Reply-To: <46770E66.70506@hhs.nl>
On Tue, Jun 19, 2007 at 12:59:50AM +0200, Hans de Goede wrote:
> Dmitry Torokhov wrote:
> >On 6/13/07, Jiri Kosina <jikos@jikos.cz> wrote:
> >>On Wed, 13 Jun 2007, Hans de Goede wrote:
> >>
> >>> Good to hear, so as everyone smees to agree, shall I write a (massive,
> >>> complex, intrusive) patch to fix this, or are there until now silent
> >>> parties that object?
> >>
> >>Well, Dmitry is the one who has final word on this, as it is related to
> >>PS/2 keyboards. Just noticed he is not in CC, added.
> >>
> >
> >Yep, just send me the patch (don't forget to make change to
> >drivers/char/keyboard.c that Vojtech mentioned in other e-mail).
> >
>
> Here is a patch as promised, attached.
>
> Thanks & Regards,
>
> Hans
Patch looks OK (didn't test it, but it seems to do all what's needed).
Acked-by: Vojtech Pavlik <vojtech@suse.cz>
> As discussed by mail change keycode for scancode e0 32 from 150 to 172
>
> Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
> diff -ur linux-2.6.22-rc4.orig/drivers/char/keyboard.c linux-2.6.22-rc4/drivers/char/keyboard.c
> --- linux-2.6.22-rc4.orig/drivers/char/keyboard.c 2007-06-16 22:54:47.000000000 +0200
> +++ linux-2.6.22-rc4/drivers/char/keyboard.c 2007-06-18 23:15:27.000000000 +0200
> @@ -1005,8 +1005,8 @@
> 284,285,309, 0,312, 91,327,328,329,331,333,335,336,337,338,339,
> 367,288,302,304,350, 89,334,326,267,126,268,269,125,347,348,349,
> 360,261,262,263,268,376,100,101,321,316,373,286,289,102,351,355,
> - 103,104,105,275,287,279,306,106,274,107,294,364,358,363,362,361,
> - 291,108,381,281,290,272,292,305,280, 99,112,257,258,359,113,114,
> + 103,104,105,275,287,279,258,106,274,107,294,364,358,363,362,361,
> + 291,108,381,281,290,272,292,305,280, 99,112,257,306,359,113,114,
> 264,117,271,374,379,265,266, 93, 94, 95, 85,259,375,260, 90,116,
> 377,109,111,277,278,282,283,295,296,297,299,300,301,293,303,307,
> 308,310,313,314,315,317,318,319,320,357,322,323,324,325,276,330,
> diff -ur linux-2.6.22-rc4.orig/drivers/input/keyboard/atkbd.c linux-2.6.22-rc4/drivers/input/keyboard/atkbd.c
> --- linux-2.6.22-rc4.orig/drivers/input/keyboard/atkbd.c 2007-06-16 22:54:48.000000000 +0200
> +++ linux-2.6.22-rc4/drivers/input/keyboard/atkbd.c 2007-06-18 23:07:24.000000000 +0200
> @@ -89,7 +89,7 @@
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> 217,100,255, 0, 97,165, 0, 0,156, 0, 0, 0, 0, 0, 0,125,
> 173,114, 0,113, 0, 0, 0,126,128, 0, 0,140, 0, 0, 0,127,
> - 159, 0,115, 0,164, 0, 0,116,158, 0,150,166, 0, 0, 0,142,
> + 159, 0,115, 0,164, 0, 0,116,158, 0,172,166, 0, 0, 0,142,
> 157, 0, 0, 0, 0, 0, 0, 0,155, 0, 98, 0, 0,163, 0, 0,
> 226, 0, 0, 0, 0, 0, 0, 0, 0,255, 96, 0, 0, 0,143, 0,
> 0, 0, 0, 0, 0, 0, 0, 0, 0,107, 0,105,102, 0, 0,112,
> @@ -111,7 +111,7 @@
> 82, 83, 80, 76, 77, 72, 69, 98, 0, 96, 81, 0, 78, 73, 55,183,
>
> 184,185,186,187, 74, 94, 92, 93, 0, 0, 0,125,126,127,112, 0,
> - 0,139,150,163,165,115,152,150,166,140,160,154,113,114,167,168,
> + 0,139,172,163,165,115,152,172,166,140,160,154,113,114,167,168,
> 148,149,147,140
> };
>
--
Vojtech Pavlik
Director SuSE Labs
next prev parent reply other threads:[~2007-06-19 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 21:47 Proposal: change keycode for scancode e0 32 from 150 to 172 Hans de Goede
2007-06-12 22:29 ` H. Peter Anvin
2007-06-13 6:06 ` Hans de Goede
2007-06-13 9:18 ` Jiri Kosina
2007-06-13 9:25 ` Hans de Goede
2007-06-13 9:32 ` Jiri Kosina
2007-06-13 13:45 ` Dmitry Torokhov
2007-06-18 22:59 ` PATCH: " Hans de Goede
2007-06-19 13:44 ` Vojtech Pavlik [this message]
2007-06-13 13:02 ` Proposal: " Vojtech Pavlik
2007-06-13 10:38 ` Vojtech Pavlik
2007-06-14 12:35 ` Stanislav Brabec
2007-06-13 10:29 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070619134416.GL6382@suse.cz \
--to=vojtech@suse.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=hpa@zytor.com \
--cc=j.w.r.degoede@hhs.nl \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=sbrabec@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox