From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Cedric Le Goater <clg@fr.ibm.com>,
Christoph Lameter <clameter@sgi.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Herbert Poetzl <herbert@13thfloor.at>,
Pavel Emelianov <xemul@openvz.org>
Subject: Re: [PATCH -mm] add a kmem_cache for nsproxy objects
Date: Tue, 19 Jun 2007 20:04:07 +0100 [thread overview]
Message-ID: <20070619190406.GA3830@infradead.org> (raw)
In-Reply-To: <20070619113501.a88bba50.akpm@linux-foundation.org>
On Tue, Jun 19, 2007 at 11:35:01AM -0700, Andrew Morton wrote:
> On Mon, 18 Jun 2007 22:53:13 +0200
> Cedric Le Goater <clg@fr.ibm.com> wrote:
>
> > +static int __init nsproxy_cache_init(void)
> > +{
> > + nsproxy_cachep = kmem_cache_create("nsproxy", sizeof(struct nsproxy),
> > + 0, SLAB_PANIC, NULL, NULL);
> > + return 0;
> > +}
> > +
>
> Christoph added this cheesy KMEM_CACHE macro. But I don't immediately recall
> the rationale so I'm a bit reluctant to ask people to use-the-cheesy-macro.
>
> Perhaps he can remind us why it is there?
Hmm, I must have missed the macro going in. Frankly speaking I plain hate
it. It's a rather useless obsfucation.
next prev parent reply other threads:[~2007-06-19 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 20:53 [PATCH -mm] add a kmem_cache for nsproxy objects Cedric Le Goater
2007-06-19 18:35 ` Andrew Morton
2007-06-19 19:04 ` Christoph Hellwig [this message]
2007-06-19 19:27 ` Christoph Lameter
2007-06-19 21:14 ` Pekka Enberg
2007-06-19 19:24 ` Christoph Lameter
2007-06-22 7:48 ` Cedric Le Goater
2007-06-22 16:22 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070619190406.GA3830@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=clg@fr.ibm.com \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox