Re: 2.6.22-rc5 regression

[Carlo Wood <carlo@alinoe.com>]

On Mon, Jun 18, 2007 at 03:57:51PM -0700, Linus Torvalds wrote:
> > I'll redo the bisect with this new git.
> 
> Thanks,
> 		Linus

Well, I did a new 'git bisect' - and if you ask me - it is still broken.

It's conclusion was this time:

hikaru:/usr/src/kernel/git/linux-2.6>git bisect bad
01da41b86f6e5f9a724e20a63f093d77e37d8056 is first bad commit
commit 01da41b86f6e5f9a724e20a63f093d77e37d8056
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date:   Sat Mar 3 01:13:35 2007 +0000

    parisc: make command_line[] static

    Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>

:040000 040000 eb42c17f2b8c686380fa540723d09e4b27127236 0a77f9c56f35076ae79f9f12a37769500c8f5ee9 M      arch

Here is the log:

hikaru:/usr/src/kernel/git/linux-2.6>git bisect log
git-bisect start
# bad: [188e1f81ba31af1b65a2f3611df4c670b092bbac] Linux 2.6.22-rc5
git-bisect bad 188e1f81ba31af1b65a2f3611df4c670b092bbac
# good: [99f9f3d49cbc7d944476f6fde53a77ec789ab2aa] Merge branch
# 'for-linus' of
# git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband
git-bisect good 99f9f3d49cbc7d944476f6fde53a77ec789ab2aa
# good: [9808901b6c63a1c850b072e624c228901a9eaf10] Blackfin serial
# driver: ignore framing and parity errors
git-bisect good 9808901b6c63a1c850b072e624c228901a9eaf10
# bad: [aba297927d1d558c7a94548135133bdf9172708a] Merge
# master.kernel.org:/pub/scm/linux/kernel/git/kyle/parisc-2.6
git-bisect bad aba297927d1d558c7a94548135133bdf9172708a
# good: [0127d6d5d925321650e7b92364420325689a03ef] Merge branch 'master'
# of master.kernel.org:/pub/scm/linux/kernel/git/davem/sparc-2.6
git-bisect good 0127d6d5d925321650e7b92364420325689a03ef
# bad: [25971f68d392f1816e21520e9e59648403b0bdad] [PARISC] fix section
# mismatch in ccio-dma
git-bisect bad 25971f68d392f1816e21520e9e59648403b0bdad
# bad: [7022672e4046fac4699aa5f8ff2a5213b7ec4ff9] [PARISC] spelling
# fixes: arch/parisc/
git-bisect bad 7022672e4046fac4699aa5f8ff2a5213b7ec4ff9
# bad: [fd3eef10f5a55acdefbd3f53ca7618a35cb6231f] [PARISC] Wire up
# kexec_load syscall
git-bisect bad fd3eef10f5a55acdefbd3f53ca7618a35cb6231f
# bad: [2c8307f63dd5caaf7ff8ad5118951e559a9ed5c8] parisc: sync compat
# getdents
git-bisect bad 2c8307f63dd5caaf7ff8ad5118951e559a9ed5c8
# bad: [01da41b86f6e5f9a724e20a63f093d77e37d8056] parisc: make
# command_line[] static
git-bisect bad 01da41b86f6e5f9a724e20a63f093d77e37d8056


Personally I am convinced that the real problem is with
8888985144db8f4cb7e56154b31bdf233d3550bf

    [AGPGART] intel_agp: fix device probe
    
    This patch trys to fix device probe in two cases. First we should
    correctly detect device if integrated graphics device is not enabled
    or exists, like an add-in card is plugged. Second on some type of intel
    GMCH, it might have multiple graphic chip models, like 945GME case, so
    we should be sure the detect works through the whole table.
    
    Signed-off-by: Wang Zhenyu <zhenyu.z.wang@intel.com>
    Signed-off-by: Dave Jones <davej@redhat.com>


The result of this patch is that the kernel starts to print
"agpgart: Detected an Intel 965G Chipset." again with the usual
disastrous results. Now, that doesn't mean that this patch is
wrong - but it explains why the problem returns after this patch.

-- 
Carlo Wood <carlo@alinoe.com>