From: Jean Delvare <khali@linux-fr.org>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: Trilok Soni <soni.trilok@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
i2c@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [i2c] [PATCH] I2C: TSL2550 support.
Date: Wed, 20 Jun 2007 11:38:42 +0200 [thread overview]
Message-ID: <20070620113842.03635603@hyperion.delvare> (raw)
In-Reply-To: <20070619144845.GJ4374@enneenne.com>
Hi Rodolfo,
On Tue, 19 Jun 2007 16:48:46 +0200, Rodolfo Giometti wrote:
> Please, note that I left LUX calculation untouched since on my data
> sheet I have only such cumputation example. :(
>
> Hope it could be ok anyway...
Datasheets typically give you one way to process the data, that doesn't
mean this is the only way, nor the best in all situations. My proposal
was mathematically equivalent to your datasheet-based implementation,
and had a lower memory footprint.
Anyway, your way works too, so it's OK. I'll take your patch as is,
optimizations can always be applied later. I wish I could give a try to
your driver, but unfortunately I still didn't manage to get my TAOS
evaluation module to work under Linux :(
--
Jean Delvare
prev parent reply other threads:[~2007-06-20 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 10:55 [PATCH] I2C: TSL2550 support Rodolfo Giometti
2007-06-19 11:28 ` Trilok Soni
2007-06-19 12:10 ` Rodolfo Giometti
2007-06-19 13:39 ` [i2c] " Jean Delvare
2007-06-19 13:51 ` Rodolfo Giometti
2007-06-19 14:47 ` Rodolfo Giometti
2007-06-20 9:45 ` Jean Delvare
2007-06-19 14:48 ` [i2c] " Rodolfo Giometti
2007-06-20 9:38 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070620113842.03635603@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=giometti@enneenne.com \
--cc=i2c@lm-sensors.org \
--cc=linux-kernel@vger.kernel.org \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox