From: Jeff Dike <jdike@addtoit.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH 2/2] UML - Add stack usage monitoring
Date: Wed, 20 Jun 2007 11:37:32 -0400 [thread overview]
Message-ID: <20070620153732.GC6728@c2.user-mode-linux.org> (raw)
In-Reply-To: <20070619125707.84cf73fd.randy.dunlap@oracle.com>
On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote:
> Kconfig help text is indented 2 more spaces (by convention or
> CodingStyle).
OK, will fix.
> > + if(*p != 0)
>
> if (*p != NULL)
p is int *, so that's a int version pointer comparision.
> or
> if (*p)
Conceptually, p is an int, not a boolean, so I prefer to type the
extra characters to do the int-to-boolean conversion in places that
want booleans.
> > + if (left < lowest_to_date) {
> > + printk("Greatest stack depth - %d bytes left\n", left);
>
> Does UML need/use KERN_* facility levels in printk() calls?
Yes, will fix.
Jeff
--
Work email - jdike at linux dot intel dot com
next prev parent reply other threads:[~2007-06-20 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 18:42 [PATCH 2/2] UML - Add stack usage monitoring Jeff Dike
2007-06-19 18:54 ` Andrew Morton
2007-06-19 19:50 ` Jeff Dike
2007-06-19 19:57 ` Randy Dunlap
2007-06-20 15:37 ` Jeff Dike [this message]
2007-06-19 20:14 ` Andrew Morton
2007-06-20 14:06 ` [uml-devel] " Blaisorblade
2007-06-20 15:17 ` Jeff Dike
2007-06-20 20:20 ` Blaisorblade
2007-06-20 18:23 ` Jeff Dike
2007-06-20 14:18 ` [uml-devel] " Blaisorblade
2007-06-20 15:20 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070620153732.GC6728@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).