public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ian McDonald <ian.mcdonald@jandi.co.nz>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Miklos Szeredi <miklos@szeredi.hu>, Ingo Molnar <mingo@elte.hu>,
	"Darrick J. Wong" <djwong@us.ibm.com>, Andi Kleen <ak@suse.de>,
	Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
	William Cohen <wcohen@redhat.com>,
	"S. P. Prasanna" <prasanna@in.ibm.com>,
	Antonino Daplas <adaplas@gmail.com>, Olaf Hering <olaf@aepfle.de>,
	Ville Syrj?l? <syrjala@sci.fi>, Jean Delvare <khali@linux-fr.org>,
	Rudolf Marek <r.marek@assembler.cz>,
	Soeren Sonnenburg <kernel@nn7.de>,
	Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Subject: Re: [1/2] 2.6.22-rc5: known regressions with patches
Date: Wed, 20 Jun 2007 19:07:51 -0400	[thread overview]
Message-ID: <20070620230751.GA15092@redhat.com> (raw)
In-Reply-To: <alpine.LFD.0.98.0706201536161.3593@woody.linux-foundation.org>

On Wed, Jun 20, 2007 at 03:38:06PM -0700, Linus Torvalds wrote:

 > And yes, that patch already got merged. However, the patch to *allow* 
 > Kprobes with DEBUG_RODATA is not, and will not be. It's not a regression, 
 > and quite frankly, I don't think I would even want that patch.
 > 
 > Kprobes fundamntally disagrees with DEBUG_RODATA, there's no point in 
 > "working around it". Better just admit it.

Surely the fundamental disagreement is only due to DEBUG_RODATA
covering write-protection of both .text, and .rodata  ?
I can see value in having a kernel that supports kprobes, whilst
at the same point, raising red flags if something writes into
a const string. With my distro kernel maintainer hat on, I always
hate these 'pick one' decisions, because I always get convincing
arguments from proponents of both sides.

Was it always this way?  I thought DEBUG_RODATA initially just
covered, well.. rodata.    And kprobes only wants to change .text
doesn't it ?

	Dave

-- 
http://www.codemonkey.org.uk

  parent reply	other threads:[~2007-06-20 23:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-17 14:23 [1/2] 2.6.22-rc5: known regressions with patches Michal Piotrowski
2007-06-17 15:16 ` Ingo Molnar
2007-06-17 15:31   ` Michal Piotrowski
2007-06-20 22:08 ` Ian McDonald
2007-06-20 22:31   ` Chuck Ebbert
2007-06-20 22:38     ` Ian McDonald
2007-06-20 22:41     ` Linus Torvalds
2007-06-20 22:38   ` Linus Torvalds
2007-06-20 22:41     ` Ian McDonald
2007-06-20 22:54       ` Linus Torvalds
2007-06-20 23:02         ` Ian McDonald
2007-06-20 23:04         ` Linus Torvalds
2007-06-21 15:46           ` Chuck Ebbert
2007-06-20 23:07     ` Dave Jones [this message]
2007-06-20 23:15       ` Arjan van de Ven
2007-06-20 23:24         ` Dave Jones
2007-06-20 23:48       ` Linus Torvalds
2007-06-21  9:19         ` [PATCH] Alternative fix for kprobes&DEBUG_RODATA was " Andi Kleen
2007-06-21 16:03           ` Linus Torvalds
2007-06-20 23:21     ` Arjan van de Ven
2007-06-20 23:50       ` Linus Torvalds
2007-06-21  5:23         ` Arjan van de Ven
2007-06-21  7:11           ` S. P. Prasanna
2007-06-21 14:35           ` Stefan Richter
2007-06-21 14:36             ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070620230751.GA15092@redhat.com \
    --to=davej@redhat.com \
    --cc=B.Steinbrink@gmx.de \
    --cc=adaplas@gmail.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=djwong@us.ibm.com \
    --cc=ian.mcdonald@jandi.co.nz \
    --cc=kernel@nn7.de \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=miklos@szeredi.hu \
    --cc=mingo@elte.hu \
    --cc=olaf@aepfle.de \
    --cc=prasanna@in.ibm.com \
    --cc=r.marek@assembler.cz \
    --cc=syrjala@sci.fi \
    --cc=torvalds@linux-foundation.org \
    --cc=wcohen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox