Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded

["Bob Picco" <bob.picco@hp.com>]

Randy Dunlap wrote:	[Wed Jun 20 2007, 09:07:11PM EDT]
> On Wed, 20 Jun 2007 20:51:22 -0400 Bob Picco wrote:
> 
> > akpm@linux-foundation.org wrote:	[Wed Jun 20 2007, 01:14:34PM EDT]
> > [snip]
> > 
> > Build breakage. pci_mmcfg_late_init is for i386.
> 
> then you want CONFIG_X86_32 instead of CONFIG_X86.
> CONFIG_X86 is set/true for both X86_32 and X86_64.
Then what I stated within the patch description is incorrect. pci.h which is the
required include for the declaration is conditionally for CONFIG_X86. So it is
both I guess?

bob
> 
> 
> > Signed-off-by: Bob Picco <bob.picco@hp.com>
> > 
> >  drivers/acpi/bus.c |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > Index: linux-2.6.22-rc5-mm1/drivers/acpi/bus.c
> > ===================================================================
> > --- linux-2.6.22-rc5-mm1.orig/drivers/acpi/bus.c	2007-06-20 14:09:07.000000000 -0400
> > +++ linux-2.6.22-rc5-mm1/drivers/acpi/bus.c	2007-06-20 20:32:00.000000000 -0400
> > @@ -757,7 +757,9 @@ static int __init acpi_init(void)
> >  	result = acpi_bus_init();
> >  
> >  	if (!result) {
> > +#ifdef CONFIG_X86
> >  		pci_mmcfg_late_init();
> > +#endif
> >  #ifdef CONFIG_PM_LEGACY
> >  		if (!PM_IS_ACTIVE())
> >  			pm_active = 1;
> 
> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***