Re: [PATCH] bracing the loop in kernel/softirq.c

[Cyrill Gorcunov <gorcunov@gmail.com>]

[Jeremy Fitzhardinge - Thu, Jun 21, 2007 at 11:52:25AM -0700]
> Jesper Juhl wrote:
>> On 20/06/07, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
>>> This trivial patch adds braces over a one-line
>>> loop. That makes code...well... little bit
>>> convenient for (possible) further modifications.
>>>
>> That's generally not done.
>>
>> It's even in Documentation/CodingStyle :
>>
>> "
>> Do not unnecessarily use braces where a single statement will do.
>>
>> if (condition)
>>        action();
>> "
>
> I tend to see "do {} while()" as an exception to this.  I find the 
> construct is sufficiently rare that it helps to emphasize it a bit.  For 
> example if I'm scanning code and I see:
>
> 	while (foo != NULL);
>
> in the corner of my eye, I'm going to think "huh?".  But:
>
> 	} while (foo != NULL);
>
> visually "parses" properly, regardless of how near or far the corresponding 
> "do  {" is.
>
> (And of course, its consistent with the super extra special while-while 
> loop:
>
> 	while (foo != NULL) {
> 		foo = bar();
> 		piffle();
> 	} while (foo != NULL);	// make sure we loop properly
>
> ;)
>
>    J
>

Btw, Jeremy, could you please Ack it then and I'll resend the patch to Andrew ;)

		Cyrill