From: David Teigland <teigland@redhat.com>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [patch] DLM: fix kconfig dependency
Date: Fri, 22 Jun 2007 13:05:01 -0500 [thread overview]
Message-ID: <20070622180500.GD6381@redhat.com> (raw)
In-Reply-To: <20070622140615.GP5193@alberich.amd.com>
On Fri, Jun 22, 2007 at 04:06:15PM +0200, Andreas Herrmann wrote:
> Avoid kernel build error (as DLM depends on SYSFS)
>
> LD vmlinux
> fs/built-in.o: In function `dlm_lockspace_init':
> : undefined reference to `kernel_subsys'
> fs/built-in.o: In function `configfs_init':
> mount.c:(.init.text+0xef4): undefined reference to `kernel_subsys'
>
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
>
> diff --git a/fs/dlm/Kconfig b/fs/dlm/Kconfig
> index 69a9469..c0e4c59 100644
> --- a/fs/dlm/Kconfig
> +++ b/fs/dlm/Kconfig
> @@ -1,5 +1,5 @@
> menu "Distributed Lock Manager"
> - depends on EXPERIMENTAL && INET
> + depends on EXPERIMENTAL && INET && SYSFS
>
> config DLM
> tristate "Distributed Lock Manager (DLM)"
There's a been a lot of back and forth on this from a number of different
people:
1/18/06 depends on SYSFS
4/25/06 - depends on SYSFS
2/05/07 + select SYSFS
2/05/07 - select SYSFS
+ depends on SYSFS
5/01/07 - depends on SYSFS
It looks like the last removal was in error and it should be added back.
Dave
next prev parent reply other threads:[~2007-06-22 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 14:06 [patch] DLM: fix kconfig dependency Andreas Herrmann
2007-06-22 18:05 ` David Teigland [this message]
2007-06-22 18:35 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070622180500.GD6381@redhat.com \
--to=teigland@redhat.com \
--cc=andreas.herrmann3@amd.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox