public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, "Vojtech Pavlik" <vojtech@ucw.cz>
Subject: Re: Writing a driver for a legacy serial device
Date: Sat, 23 Jun 2007 10:34:35 +0200	[thread overview]
Message-ID: <20070623103435.7c54d047@hyperion.delvare> (raw)
In-Reply-To: <d120d5000706221247g618fffadh2c4296aa62a39b9e@mail.gmail.com>

Hi Dmitry,

On Fri, 22 Jun 2007 15:47:43 -0400, Dmitry Torokhov wrote:
> On 6/21/07, Jean Delvare <khali@linux-fr.org> wrote:
> >
> > OK. This leads me to a question: is it OK for me to add support for my
> > non-input device to inputattach, or is a separate, dedicated helper
> > tool preferred? Both ways are fine with me, I don't know what the input
> > subsystem maintainers expect.
> 
> Your device does not need any initialization done by userspace, does
> it?

No, it doesn't. But it wants a specific serial line speed and mode.

> How widespread is this device?

Not widespread. It's a family of evaluation modules for I2C/SMBus
chips. They will mainly be used to develop and test chip drivers, I
suppose. But OTOH, I'm not sure how it matters. We're in year 2007, I
pretty much doubt that any of the devices supported by inputattach is
still in widespread use. As a matter of fact, inputattach has been
broken in Suse for half of the supported devices for almost two years
now, and I couldn't find any bug report about it.

> inputattach has "--dump" option
> which sets up a SERIO_RS232/0/0/0 serio port. You could mark your
> serio driver as manual bind driver and bind it trhough sysfs (echo -n
> "taos-evm" /sys/device/serio/devices/serioX/drvctl to bind it).

One problem I foresee is that the dump mode sets the port to 2400 bps,
while my evaluation module wants 1200 bps.

Another problem is that the dump mode of inputattach doesn't appear to
create a serio device. Probably not very surprising, as dump_init()
never returns. So I don't think I can use that.

-- 
Jean Delvare

      reply	other threads:[~2007-06-23  8:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 17:05 Writing a driver for a legacy serial device Jean Delvare
2007-06-19 18:59 ` Dmitry Torokhov
2007-06-20  8:56   ` Jean Delvare
2007-06-21  3:11     ` Dmitry Torokhov
2007-06-21  9:33       ` Jean Delvare
2007-06-21 14:47         ` David Woodhouse
2007-06-21 18:38           ` Jean Delvare
2007-06-21 23:31             ` Arnd Bergmann
2007-06-22 19:47         ` Dmitry Torokhov
2007-06-23  8:34           ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070623103435.7c54d047@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox