Re: [PATCH] x86-64: disable the GART in shutdown

Muli Ben-Yehuda
2007-06-23T11:09:39Z

On Sat, Jun 23, 2007 at 12:59:17PM +0200, Andi Kleen wrote:
>
> > I'm going to need exactly the same hook fro Calgary, as well Intel for
> > VT-d, and AMD for their upcoming IOMMU, etc. How about we do
> >
> > struct iommu_ops {
> > struct dma_ops {
> > ...
> > }
> > void (*shutdown)(void);
> > }
> >
> > And then pci_iommu_shutdown() becomes
> >
> > if (iommu_ops->shutdown)
> > iommu_ops->shutdown();
>
> I think it's cleaner if everybody registers their own shutdown
> handler in sysfs Don't see any value in going through a generic
> layer because there is no shared code.

Going through the shared layer makes it obvious to new IOMMU
implementers that they will need to implement a shutdown hook and
takes roughly the same ammount of work. I think that's a net win.

Cheers,
Muli