Re: [PATCH] x86-64: disable the GART before allocate aperture

Eric W. Biederman
2007-06-22T23:15:07Z

Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

> On Fri, 22 Jun 2007 15:57:08 -0700
> Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
>> Alan Cox wrote:
>>
>> > Don't disable it, just don't touch it or any of its mappings. Leave it
>> > *alone*, and use swiotlb. That'll maximise the ability to recover stuff
>> > from the kexec kernel (since for one you may want to dump the gart when a
>> > 3d app goes kerblam)
>>
>> How about LinuxBIOS + Kernel ===> Final kernel path?
>> someday EFI(PEI) + Kernel ===> Final kernel path need that too.
>>
>> or the normal kexec path still could have clean shutdown.
>
> The kexec path for kdump should be swiotlb and leave the GART alone as
> you are dumping as much state as you can and leaving stuff as is when
> possible. The new-kernel case you shut everything down so you can shut
> down the GART in the old kernel and re-initialise it in the new one

Agreed.

Eric