Re: [REGRESSION 2.6-git] possible circular locking dependency detected with XFS

[David Chinner <dgc@sgi.com>]

On Sat, Jun 23, 2007 at 12:53:11AM +0200, Michal Piotrowski wrote:
> Hi Oliver,
> 
> On 22/06/07, Oliver Pinter <oliver.pntr@gmail.com> wrote:
> >Hi all!
> >
> >I found this info:
> >
> >======================================================= [ INFO: possible
> >circular locking dependency detected ] 2.6.22-rc5-wifi1 #2
> >------------------------------------------------------- mount/2209 is
> >trying to acquire lock: (&(&ip->i_lock)->mr_lock/1){--..}, at: [<c022b62d>]
> >xfs_ilock+0x66/0x90
> >
> >but task is already holding lock: (&(&ip->i_lock)->mr_lock){----}, at:
> >[<c022b62d>] xfs_ilock+0x66/0x90
> >
> 
> AFAIR it is not a regression. It is a known bug (harmless).

FWIW, it's not even a bug. The bug (if any) is due to the fact we
can't properly express the XFS locking rules with lockdep. We
recently added a bunch of notations that fixed the common false
positives we were seeing, but as a result, it appears we now have a
whole new set of false positive reports coming in that are even
harder to fix.

As Christoph Hellwig has previously noted, the correct way to fix
this in XFS is to completely change the locking within XFS directory
operations to do strict parent/child locking like the VFS does.
Unfortunately, that's not as simple as it sounds, because inode
flushing and log tail pushing rely on inodes being locked in
ascending inode order to prevent deadlocks within XFS. 

That means when we lock multiple inodes in link, rename, etc, we
have to lock them in ascending order. The exception to this is
create, mkdir, mknod because the newly created inode will not be
locked by definition so it is always safe to lock it.

Hence if the new inode's number is less than the parent inode's
number we can get lockdep warning about circular locking
dependencies which don't actually exist. That is where this warning
is coming from....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group