public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes-kernel@saeurebad.de>
To: vignesh babu <vignesh.babu@wipro.com>
Cc: daniel.pirkl@email.cz, dushistov@mail.ru,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Kernel Janitors List <kernel-janitors@lists.osdl.org>
Subject: Re: [PATCH]is_power_of_2-ufs/super.c
Date: Mon, 25 Jun 2007 14:13:16 +0200	[thread overview]
Message-ID: <20070625121316.GA19544@saeurebad.de> (raw)
In-Reply-To: <1181808559.2474.9.camel@merlin.linuxcoe.com>

Hi,

On Thu, Jun 14, 2007 at 01:39:18PM +0530, vignesh babu wrote:
> Replacing (n & (n-1)) in the context of power of 2 checks
> with is_power_of_2

You might want to run

	egrep -R '([a-zA-Z0-9_.>]+) *& *\(\1 *- *1\)' /usr/src/linux

This does not match if the check is broken into multiple lines, though.
Still, 66 matches so far. Perhaps a big patch that removes most of these
occurrences would be more appropriate.

	Hannes

  parent reply	other threads:[~2007-06-25 12:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-14  8:09 [PATCH]is_power_of_2-ufs/super.c vignesh babu
2007-06-14 17:50 ` [PATCH]is_power_of_2-ufs/super.c Evgeniy Dushistov
2007-06-25 12:13 ` Johannes Weiner [this message]
2007-06-25 12:21   ` [PATCH]is_power_of_2-ufs/super.c vignesh babu
2007-06-25 12:27   ` [PATCH]is_power_of_2-ufs/super.c Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070625121316.GA19544@saeurebad.de \
    --to=hannes-kernel@saeurebad.de \
    --cc=daniel.pirkl@email.cz \
    --cc=dushistov@mail.ru \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vignesh.babu@wipro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox