From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
perex@suse.cz, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: fix ice1712 section mismatch
Date: Mon, 25 Jun 2007 16:41:10 -0700 [thread overview]
Message-ID: <20070625164110.94ecade1.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070625161739.8115c40c.randy.dunlap@oracle.com>
On Mon, 25 Jun 2007 16:17:39 -0700 Randy Dunlap <randy.dunlap@oracle.com>
wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Cannot mix const and __initdata:
> sound/pci/ice1712/prodigy192.c:708: error: ak4114_controls causes a section type conflict
>
This is a fatal compilation error, isn't it?
> ---
> sound/pci/ice1712/prodigy192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.22-rc6.orig/sound/pci/ice1712/prodigy192.c
> +++ linux-2.6.22-rc6/sound/pci/ice1712/prodigy192.c
> @@ -705,7 +705,7 @@ static int ak4114_input_sw_put(struct sn
> }
>
>
> -static const struct snd_kcontrol_new ak4114_controls[] __devinitdata = {
> +static struct snd_kcontrol_new ak4114_controls[] __devinitdata = {
> {
> .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> .name = "MIODIO IEC958 Capture Input",
That patch is already in the alsa git tree (has been there for five days),
so I would of course prefer that the alsa guys merge it into 2.6.22.
However alsa merges are a bit spotty, so I'll queue this up anyway and will
merge it in a day or three if nothing else happens, OK?
next prev parent reply other threads:[~2007-06-25 23:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 23:17 [PATCH] ALSA: fix ice1712 section mismatch Randy Dunlap
2007-06-25 23:41 ` Andrew Morton [this message]
2007-06-25 23:47 ` Randy Dunlap
2007-06-26 9:10 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070625164110.94ecade1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=randy.dunlap@oracle.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox