From: Sam Ravnborg <sam@ravnborg.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
christopher.leech@intel.com, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] IOATDMA: fix section mismatches
Date: Tue, 26 Jun 2007 06:34:02 +0200 [thread overview]
Message-ID: <20070626043402.GA18269@uranus.ravnborg.org> (raw)
In-Reply-To: <20070625145147.c34cbfca.randy.dunlap@oracle.com>
On Mon, Jun 25, 2007 at 02:51:47PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Rename struct pci_driver data so that false section mismatch
> warnings won't be produced.
>
> Sam, ISTM that depending on variable names is the weakest & worst part of
> modpost section checking. Should __init_refok work here? I got build
> errors when I tried to use it, probably because the struct pci_driver
> probe and remove methods are not marked "__init_refok".
Relying on naming is obviously a bad thing but without doing so
we would have tons of warnings from drivers/
__init_refok is for functions. For this case __initdata_refok
could have worked but to be consistent the renaming is much
better.
Sam
prev parent reply other threads:[~2007-06-26 4:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 21:51 [PATCH] IOATDMA: fix section mismatches Randy Dunlap
2007-06-26 4:34 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626043402.GA18269@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=christopher.leech@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox