From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757374AbXF0E7q (ORCPT ); Wed, 27 Jun 2007 00:59:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752130AbXF0E7h (ORCPT ); Wed, 27 Jun 2007 00:59:37 -0400 Received: from gateway.insightbb.com ([74.128.0.19]:10291 "EHLO asav05.insightbb.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999AbXF0E7h (ORCPT ); Wed, 27 Jun 2007 00:59:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoQrAKyLgUZKhRO4R2dsb2JhbACBT4Vdh3MBARsNBhEB From: Dmitry Torokhov To: Greg KH Subject: Re: [PATCH] atkbd: cleanup only once Date: Wed, 27 Jun 2007 00:59:32 -0400 User-Agent: KMail/1.9.3 Cc: Dave Young , linux-kernel@vger.kernel.org References: <20070627105907.GA1802@darkstar.te-china.tietoenator.com> <200706270034.09802.dtor@insightbb.com> <20070627042820.GC13513@suse.de> In-Reply-To: <20070627042820.GC13513@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200706270059.33550.dtor@insightbb.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 27 June 2007 00:28, Greg KH wrote: > On Wed, Jun 27, 2007 at 12:34:09AM -0400, Dmitry Torokhov wrote: > > Hi Dave, > > > > On Wednesday 27 June 2007 06:59, Dave Young wrote: > > > Hi, > > > > > > If you press ctrl+alt+del several times as kernel booting (before user level bootin), the kernel will oops. I found the ps2_command is called more than once, then the ps2dev->serio maybe NULL pointer. > > > > > > 2.6.22-rc5 and 2.6.22-rc6 have same result. > > > > > > Signed-off-by: Dave Young > > > --- > > > diff -upr linux/drivers/input/keyboard/atkbd.c linux.new/drivers/input/keyboard/atkbd.c > > > --- linux/drivers/input/keyboard/atkbd.c 2007-06-27 10:38:37.000000000 +0000 > > > +++ linux.new/drivers/input/keyboard/atkbd.c 2007-06-27 10:37:39.000000000 +0000 > > > @@ -795,6 +795,11 @@ static int atkbd_activate(struct atkbd * > > > > > > static void atkbd_cleanup(struct serio *serio) > > > { > > > + static int flag; > > > + > > > + if(flag) > > > + return; > > > + flag = 1; > > > > Unfortunately this will prevent atkbd from resetting keyboard on 2nd > > suspend attempt. It will also not work if you have an active MUX and > > have a couple of keyboards connected. > > > > Greg, now that you removed rwsem from subsystem (and subsystem itself > > for that matter) there is nothing as far as I can see that stops > > several threads from running device_shutdown() simultaneously. I also > > do not see what would isolate device probing and shutting them down > > at the same time. Am I missing something? > > There was never anything stopping that from happening before. No driver > core code was using that rwsem, so it wasn't protecting anything, > despite people trying to use it as if it was :) > It did protect device_shutdown() from itself, didn't it? -- Dmitry