From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: menage@google.com, Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Balbir Singh <balbir@in.ibm.com>,
svaidy@linux.vnet.ibm.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix for bad lock balance in Containers
Date: Wed, 27 Jun 2007 12:08:15 +0530 [thread overview]
Message-ID: <20070627063815.GA3488@in.ibm.com> (raw)
In-Reply-To: <20070626050011.GA12584@linux.vnet.ibm.com>
On Tue, Jun 26, 2007 at 10:30:11AM +0530, Dhaval Giani wrote:
>
> --- linux-2.6.22-rc4/kernel/container.c 2007-06-13 15:38:32.000000000 +0530
> +++ old/kernel/container.c 2007-06-25 00:55:03.000000000 +0530
> @@ -995,6 +995,7 @@ static int container_get_sb(struct file_
> BUG_ON(ret);
> } else {
> /* Reuse the existing superblock */
> + down_write(&(root->sb->umount));
> ret = simple_set_mnt(mnt, root->sb);
> if (!ret)
> atomic_inc(&root->sb->s_active);
Do you want to change this to first take refererence on sb and then
do simple_set_mnt() ?
And btw, simple_set_mnt() always returns zero and looks like it can't fail.
Regards,
Bharata.
next prev parent reply other threads:[~2007-06-27 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 5:00 [PATCH] Fix for bad lock balance in Containers Dhaval Giani
2007-06-27 6:38 ` Bharata B Rao [this message]
2007-06-27 7:34 ` Dhaval Giani
2007-06-28 23:09 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070627063815.GA3488@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox